Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: integrate plugin framework with TiDB (#9006) #9888

Merged
merged 2 commits into from
Mar 25, 2019
Merged

*: integrate plugin framework with TiDB (#9006) #9888

merged 2 commits into from
Mar 25, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Mar 25, 2019

cherry-pick #9006 to 2.1


This change is Reviewable

@lysu
Copy link
Contributor Author

lysu commented Mar 25, 2019

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1 pd=release-2.1

executor/show.go Outdated Show resolved Hide resolved
@jackysp
Copy link
Member

jackysp commented Mar 25, 2019

Should we upgrade the go version on release-2.1?

@lysu
Copy link
Contributor Author

lysu commented Mar 25, 2019

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason
Copy link
Member

LGTM

@lysu
Copy link
Contributor Author

lysu commented Mar 25, 2019

/integration-common-test tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1 pd=release-2.1

@jackysp
Copy link
Member

jackysp commented Mar 25, 2019

/run-integration-common-test tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1 pd=release-2.1

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit b2492a5 into pingcap:release-2.1 Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants