Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Change runTestConcurrentUpdate to use runTestsOnNewDB #9906

Merged
merged 4 commits into from
Apr 1, 2019

Conversation

kolbe
Copy link
Contributor

@kolbe kolbe commented Mar 26, 2019

What problem does this PR solve?

Fixes #4205

What is changed and how it works?

Issue #4205 reported a problem with server/server_test.go:runTestConcurrentUpdate() encountering a problem with no database being selected when it invokes runTestsOnNewDB(). This patch simply adds explicit use statements for each transaction started in this test.

Check List

Tests

This PR fixes a test.

@kolbe kolbe requested a review from breezewish March 26, 2019 20:35
@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@77e91d1). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master      #9906   +/-   ##
===========================================
  Coverage          ?   77.5639%           
===========================================
  Files             ?        403           
  Lines             ?      81837           
  Branches          ?          0           
===========================================
  Hits              ?      63476           
  Misses            ?      13660           
  Partials          ?       4701

@imtbkcat imtbkcat changed the title Change runTestConcurrentUpdate to use runTestsOnNewDB (issue #4205) server: change runTestConcurrentUpdate to use runTestsOnNewDB (issue #4205) Apr 1, 2019
@imtbkcat imtbkcat changed the title server: change runTestConcurrentUpdate to use runTestsOnNewDB (issue #4205) server: Change runTestConcurrentUpdate to use runTestsOnNewDB (issue #4205) Apr 1, 2019
Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtbkcat imtbkcat added component/server status/LGT1 Indicates that a PR has LGTM 1. labels Apr 1, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason changed the title server: Change runTestConcurrentUpdate to use runTestsOnNewDB (issue #4205) server: Change runTestConcurrentUpdate to use runTestsOnNewDB Apr 1, 2019
@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 1, 2019
@zz-jason zz-jason merged commit 2ee8f42 into pingcap:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/server status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concurrent Transaction "No database selected" when database is not specified in connection string
3 participants