Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix group_concat for cases like group_concat(123,null) (#9921) #9930

Merged
merged 2 commits into from
Mar 28, 2019
Merged

executor: fix group_concat for cases like group_concat(123,null) (#9921) #9930

merged 2 commits into from
Mar 28, 2019

Conversation

XuHuaiyu
Copy link
Contributor

cherry-pick #9921

@XuHuaiyu XuHuaiyu added type/bugfix This PR fixes a bug. sig/execution SIG execution type/2.1 cherry-pick labels Mar 28, 2019
@XuHuaiyu
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 pd=release-2.1 tikv=release-2.1

winoros
winoros reviewed Mar 28, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

zimulala
zimulala reviewed Mar 28, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 28, 2019
@zimulala zimulala merged commit 0f69856 into pingcap:release-2.1 Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@zimulala zimulala zimulala approved these changes

@eurekaka eurekaka Awaiting requested review from eurekaka

Assignees
No one assigned
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XuHuaiyu @zimulala @winoros