change once to always

pingcap · May 18, 2022 · 512d349 · 512d349
1 parent 4bd1f17
commit 512d349
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/dbms/src/Common/FailPoint.cpp b/dbms/src/Common/FailPoint.cpp
@@ -65,8 +65,7 @@ std::unordered_map<String, std::shared_ptr<FailPointChannel>> FailPointHelper::f
  M(exception_when_read_from_log) \
  M(exception_mpp_hash_build) \
  M(exception_before_drop_segment) \
- M(exception_after_drop_segment) \
- M(force_change_all_blobs_to_read_only_once)
+ M(exception_after_drop_segment)
 
 #define APPLY_FOR_FAILPOINTS(M) \
  M(force_set_page_file_write_errno) \
@@ -83,7 +82,8 @@ std::unordered_map<String, std::shared_ptr<FailPointChannel>> FailPointHelper::f
  M(force_no_local_region_for_mpp_task) \
  M(force_remote_read_for_batch_cop) \
  M(force_context_path) \
- M(force_slow_page_storage_snapshot_release)
+ M(force_slow_page_storage_snapshot_release) \
+ M(force_change_all_blobs_to_read_only)
 
 #define APPLY_FOR_FAILPOINTS_ONCE_WITH_CHANNEL(M) \
  M(pause_with_alter_locks_acquired) \

diff --git a/dbms/src/Storages/Page/V3/BlobStore.cpp b/dbms/src/Storages/Page/V3/BlobStore.cpp
@@ -51,7 +51,7 @@ extern const int CHECKSUM_DOESNT_MATCH;
 
 namespace FailPoints
 {
-extern const char force_change_all_blobs_to_read_only_once[];
+extern const char force_change_all_blobs_to_read_only[];
 } // namespace FailPoints
 
 namespace PS::V3
@@ -876,7 +876,7 @@ std::vector<BlobFileId> BlobStore::getGCStats()
  std::vector<BlobFileId> blob_need_gc;
  BlobStoreGCInfo blobstore_gc_info;
 
- fiu_do_on(FailPoints::force_change_all_blobs_to_read_only_once,
+ fiu_do_on(FailPoints::force_change_all_blobs_to_read_only,
  {
  for (const auto & [path, stats] : stats_list)
  {
@@ -886,7 +886,7 @@ std::vector<BlobFileId> BlobStore::getGCStats()
  stat->changeToReadOnly();
  }
  }
- LOG_FMT_WARNING(log, "enabled force_change_all_blobs_to_read_only_once. All of BlobStat turn to READ-ONLY");
+ LOG_FMT_WARNING(log, "enabled force_change_all_blobs_to_read_only. All of BlobStat turn to READ-ONLY");
  });
 
  for (const auto & [path, stats] : stats_list)