catch exception of LocalAdmissionController::stop() (#8942) (#9062)

close #8860
pingcap · May 20, 2024 · f032a2e · f032a2e
1 parent 79f5b12
commit f032a2e
Showing 1 changed file with 13 additions and 1 deletion.
diff --git a/dbms/src/Flash/ResourceControl/LocalAdmissionController.h b/dbms/src/Flash/ResourceControl/LocalAdmissionController.h
@@ -442,7 +442,19 @@ class LocalAdmissionController final : private boost::noncopyable
         background_threads.emplace_back([this] { this->watchGAC(); });
     }
 
-    ~LocalAdmissionController() { stop(); }
+    ~LocalAdmissionController() { safeStop(); }
+
+    void safeStop()
+    {
+        try
+        {
+            stop();
+        }
+        catch (...)
+        {
+            LOG_ERROR(log, "stop server id({}) failed: {}", unique_client_id, getCurrentExceptionMessage(false));
+        }
+    }
 
     void consumeCPUResource(const std::string & name, double ru, uint64_t cpu_time_in_ns)
     {