fix crash when stopping because of lac reset (#8637)

close #8550
pingcap · Jan 2, 2024 · f6ea813 · f6ea813
1 parent 7d6bec8
commit f6ea813
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/dbms/src/Server/Server.cpp b/dbms/src/Server/Server.cpp
@@ -1774,8 +1774,11 @@ int Server::main(const std::vector<std::string> & /*args*/)
             {
                 assert(TaskScheduler::instance);
                 TaskScheduler::instance.reset();
+                // Stop LAC instead of reset, because storage layer still needs it.
+                // Workload will not be throttled when LAC is stopped.
+                // It's ok because flash service has already been destructed, so throllting is meaningless.
                 assert(LocalAdmissionController::global_instance);
-                LocalAdmissionController::global_instance.reset();
+                LocalAdmissionController::global_instance->stop();
             }
         });