Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libdaemon comments #2179

Closed
SchrodingerZhu opened this issue Jun 16, 2021 · 0 comments · Fixed by #4484
Closed

libdaemon comments #2179

SchrodingerZhu opened this issue Jun 16, 2021 · 0 comments · Fixed by #4484
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@SchrodingerZhu
Copy link
Contributor

there seems to be quite a lot comments in Russian at libdaemon. I think it is very unfriendly to our current develop routines. Please translate them into English.
@JaySon-Huang JaySon-Huang added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Aug 6, 2021
@ywqzzy ywqzzy mentioned this issue Mar 30, 2022
Merged
12 tasks
@JaySon-Huang JaySon-Huang added the type/enhancement The issue or PR belongs to an enhancement. label Mar 30, 2022
ti-chi-bot pushed a commit that referenced this issue Mar 30, 2022
@JaySon-Huang
Logger: Remove stringstream in total (#4484)
a1b2035 
close #2179, close #4346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Logger: Remove stringstream in total JaySon-Huang/tiflash
2 participants
@JaySon-Huang @SchrodingerZhu