Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TPCC data cannot be reclaimed after tiflash replica set to 0 #3659

Closed
lidezhu opened this issue Dec 16, 2021 · 1 comment · Fixed by #3657
Closed

TPCC data cannot be reclaimed after tiflash replica set to 0 #3659

lidezhu opened this issue Dec 16, 2021 · 1 comment · Fixed by #3657
Assignees
@lidezhu
Labels
affects-5.0 affects-5.1 affects-5.2 affects-5.3 severity/critical type/bug The issue is confirmed as a bug.

Comments

@lidezhu
Copy link
Contributor

lidezhu commented Dec 16, 2021

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. load tpcc data to tidb and set tiflash replica to 1
  2. set tiflash repclia to 0

2. What did you expect to see? (Required)

tiflash storage space should be reclaimed after some time

3. What did you see instead (Required)

tiflash storage space is not reclaimed

4. What is your TiFlash version? (Required)

master
@lidezhu lidezhu added the type/bug The issue is confirmed as a bug. label Dec 16, 2021
@lidezhu lidezhu self-assigned this Dec 16, 2021
@lidezhu lidezhu mentioned this issue Dec 16, 2021
Merged
4 tasks
@ilovesoup
Copy link
Contributor

ilovesoup commented Dec 19, 2021 •
edited
Loading

  1. Does this only apply to master?
  2. What's the worst case scenario?

@ti-chi-bot ti-chi-bot mentioned this issue Dec 21, 2021
Merged
4 tasks
This was referenced Dec 21, 2021
Merged
Merged
Merged
ti-chi-bot pushed a commit that referenced this issue Apr 12, 2022
@lidezhu
Do background compaction when the ratio of stable data covered by del…
1af8ecb 
…ete range is too large (#3695)

close #3659
ti-chi-bot pushed a commit that referenced this issue Jun 3, 2022
@lidezhu
Do background compaction when the ratio of stable data covered by del…
2f8f481 
…ete range is too large (#3703)

close #3659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidezhu lidezhu

Labels
affects-5.0 affects-5.1 affects-5.2 affects-5.3 severity/critical type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix background gc when rows covered by delete range is larger than stable lidezhu/tics
5 participants
@ilovesoup @jebter @JaySon-Huang @lilinghai @lidezhu