Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

killing mpp query raise tiflash oom when enable_elastic_threadpool #4098

Closed
lilinghai opened this issue Feb 23, 2022 · 0 comments · Fixed by #4221
Closed

killing mpp query raise tiflash oom when enable_elastic_threadpool #4098

lilinghai opened this issue Feb 23, 2022 · 0 comments · Fixed by #4221
Assignees
@fuzhe1989
Labels
affects-5.4 severity/major type/bug The issue is confirmed as a bug.

Comments

@lilinghai
Copy link

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

chbenchmark workload, kill query for loop
image

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiFlash version? (Required)

master
@lilinghai lilinghai added type/bug The issue is confirmed as a bug. severity/major labels Feb 23, 2022
This was referenced Mar 9, 2022
Merged
Merged
ti-chi-bot pushed a commit that referenced this issue Mar 11, 2022
@fuzhe1989
*: Fix memory leak when MPMCQueue destruct with non-poped elements (#…
f50e1a9 
…4221)

close #4098
@ti-chi-bot ti-chi-bot mentioned this issue Mar 11, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Mar 11, 2022
@fuzhe1989
*: Fix bug that DynamicThreadPool may not destruct tasks in time. (#4210
86e21ef 
)

ref #4098, ref #4207
@ti-chi-bot ti-chi-bot mentioned this issue Mar 11, 2022
Merged
12 tasks
@en-jin19 en-jin19 mentioned this issue Apr 6, 2022
Merged
15 tasks
ti-chi-bot added a commit that referenced this issue Apr 22, 2022
@ti-chi-bot
*: Fix bug that DynamicThreadPool may not destruct tasks in time. (#4210
bb5f9f2 
) (#4231)

ref #4098, ref #4207
ti-chi-bot added a commit that referenced this issue Apr 22, 2022
@ti-chi-bot
*: Fix memory leak when MPMCQueue destruct with non-poped elements (#…
08e993f 
…4221) (#4230)

close #4098
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fuzhe1989 fuzhe1989

Labels
affects-5.4 severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: Fix memory leak when MPMCQueue destruct with non-poped elements fuzhe1989/tiflash
3 participants
@fuzhe1989 @lilinghai @ti-chi-bot