Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated min-tso query hang and tiflash crash #4366

Closed
fzhedu opened this issue Mar 21, 2022 · 0 comments · Fixed by #4367
Closed

updated min-tso query hang and tiflash crash #4366

fzhedu opened this issue Mar 21, 2022 · 0 comments · Fixed by #4367
Assignees
Labels
affects-6.0 severity/critical type/bug The issue is confirmed as a bug.

Comments

@fzhedu
Copy link
Contributor

fzhedu commented Mar 21, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

after #4307, scheduling new tasks only after releasing threads by threads, there comes a bug: after deleting a finished query, the min-tso query would be updated, if the updated min-tso query has waiting tasks, and no threads is released possiblely due to resouces deadlock, then the updated min-tso query would hang.

on the other hand, when the finish processing of this task schedules new tasks, the possible exceptions should be thrown to the to-be-scheduled query, rather than the current task. If this happen, the destruction of the current task would terminate the tiflash process.

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiFlash version? (Required)

master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.0 severity/critical type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants