Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant files in TiFlash repo #4394

Closed
5 tasks done
Lloyd-Pottiger opened this issue Mar 23, 2022 · 1 comment · Fixed by #4413
Closed
5 tasks done

Remove redundant files in TiFlash repo #4394

Lloyd-Pottiger opened this issue Mar 23, 2022 · 1 comment · Fixed by #4413
Assignees
@ywqzzy
Labels
type/code-quality-improvement PR that can improve the code quality type/enhancement The issue or PR belongs to an enhancement.

Comments

@Lloyd-Pottiger
Copy link
Contributor

Lloyd-Pottiger commented Mar 23, 2022 •
edited by ywqzzy
Loading

Enhancement

Redundant files like

  • CollapsingFinalBlockInputStream.h
  • CollapsingFinalBlockInputStream.cpp
  • InBlockDedupBlockOutputStream.h
  • DedupSortedBlockInputStream.h
  • DedupSortedBlockInputStream.cpp
@Lloyd-Pottiger Lloyd-Pottiger added type/enhancement The issue or PR belongs to an enhancement. type/code-quality-improvement PR that can improve the code quality labels Mar 23, 2022
@Lloyd-Pottiger Lloyd-Pottiger mentioned this issue Mar 23, 2022
Merged
12 tasks
@ywqzzy
Copy link
Contributor

ywqzzy commented Mar 24, 2022

/assign @ywqzzy

@ywqzzy ywqzzy mentioned this issue Mar 24, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Mar 24, 2022
@ywqzzy
Remove duplicated streams code. (#4413)
a314e93 
close #4394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ywqzzy ywqzzy

Labels
type/code-quality-improvement PR that can improve the code quality type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove duplicated streams code. ywqzzy/tiflash_1
2 participants
@ywqzzy @Lloyd-Pottiger