Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metadata corruption by cherry pick from tikv #4437

Closed
CalvinNeo opened this issue Mar 25, 2022 · 1 comment · Fixed by pingcap/tidb-engine-ext#53 or #4453
Closed

Fix metadata corruption by cherry pick from tikv #4437

CalvinNeo opened this issue Mar 25, 2022 · 1 comment · Fixed by pingcap/tidb-engine-ext#53 or #4453
Labels
affects-5.2 affects-5.3 affects-5.4 affects-6.0 may-affects-5.0 may-affects-5.1 severity/critical type/bug The issue is confirmed as a bug.

Comments

@CalvinNeo
Copy link
Member

CalvinNeo commented Mar 25, 2022 •
edited by JaySon-Huang
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

As tikv/tikv#11526 describe

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiFlash version? (Required)
@CalvinNeo CalvinNeo added the type/bug The issue is confirmed as a bug. label Mar 25, 2022
@CalvinNeo CalvinNeo mentioned this issue Mar 25, 2022
Merged
12 tasks
@CalvinNeo CalvinNeo changed the title Fix Fix metadata corruption by cherry pick from tikv Mar 25, 2022
CalvinNeo added a commit to pingcap/tidb-engine-ext that referenced this issue Mar 28, 2022
@CalvinNeo @BusyJay @ti-chi-bot
Cherry pick: raftstore: set term when catch up logs for merge
5874ff9 
Cherry pick to fix pingcap/tiflash#4437.

* add test case

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

* raftstore: set term when catch up logs for merge

Prepare merge may includes logs from different terms, which may be even
larger than the term of a follower that is lag behind. So when catching
up logs by commit merge, its term should also be set to get a correct
metadata.

Close tikv#11526.

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

* add log for becoming follower

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

* correct commit log check

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>

Co-authored-by: Jay <BusyJay@users.noreply.github.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@CalvinNeo CalvinNeo reopened this Mar 28, 2022
@CalvinNeo CalvinNeo mentioned this issue Mar 28, 2022
Merged
12 tasks
This was referenced Mar 30, 2022
Closed
Closed
Merged
ti-chi-bot pushed a commit that referenced this issue Mar 30, 2022
@CalvinNeo
update tiflash proxy version to adopt bugfix from TiKV (#4453)
aa62633 
close #4437
ti-chi-bot pushed a commit that referenced this issue Mar 30, 2022
@CalvinNeo
update tiflash proxy version to adopt bugfix from TiKV in 6.0 (#4491)
25545c4 
ref #4437
This was referenced Mar 30, 2022
Merged
Merged
Merged
Merged
ti-chi-bot pushed a commit that referenced this issue Apr 12, 2022
@solotzg
Fix metadata corruption & Merge tikv/release-5.2 to release-5.2 (#4499)
0f33c53 
close #3435, close #4437
@VelocityLight
Copy link

update

ti-chi-bot pushed a commit that referenced this issue Apr 22, 2022
@solotzg
Fix metadata corruption release-5.4 (#4496)
839a659 
close #2576, close #3435, close #4437
ti-chi-bot pushed a commit that referenced this issue Apr 22, 2022
@solotzg
Fix metadata corruption & Merge tikv/release-5.1 to release-5.1 (#4501)
adf43ea 
close #2576, close #3435, close #4437
ti-chi-bot pushed a commit that referenced this issue Apr 22, 2022
@solotzg
Fix metadata corruption release-5.3 (#4495)
f3ec98d 
close #2576, close #3435, close #4437
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.2 affects-5.3 affects-5.4 affects-6.0 may-affects-5.0 may-affects-5.1 severity/critical type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
7 participants
@jebter @JaySon-Huang @CalvinNeo @lilinghai @VelocityLight @solotzg @ti-chi-bot