Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in README/build #4560

Closed
ywqzzy opened this issue Apr 1, 2022 · 1 comment · Fixed by #4561
Closed

Fix typo in README/build #4560

ywqzzy opened this issue Apr 1, 2022 · 1 comment · Fixed by #4561
Assignees
@qian0817
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@ywqzzy
Copy link
Contributor

ywqzzy commented Apr 1, 2022

Enhancement

Change

cd $BUILD
cmake $WORKSPACE/tiflash -Gninja
ninja tiflash

to

cd $BUILD
cmake $WORKSPACE/tiflash -GNinja
ninja tiflash
@ywqzzy ywqzzy added type/enhancement The issue or PR belongs to an enhancement. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Apr 1, 2022
@qian0817
Copy link
Contributor

qian0817 commented Apr 1, 2022

assign me.

@qian0817 qian0817 mentioned this issue Apr 1, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Apr 1, 2022
@qian0817
Fix typo in README/build (#4561)
673c9c9 
close #4560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qian0817 qian0817

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typo in README/build qian0817/tiflash
2 participants
@ywqzzy @qian0817