Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless clickhouse functions. #4640

Open
ywqzzy opened this issue Apr 13, 2022 · 0 comments
Open

Remove useless clickhouse functions. #4640

ywqzzy opened this issue Apr 13, 2022 · 0 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@ywqzzy
Copy link
Contributor

ywqzzy commented Apr 13, 2022

Enhancement

There are many functions in old clickhouse code which are not used.
We can delete some of them in order to make the code clean and accelerate the build process.

For example:
TiFlash has implemented the tiDBIPv6NumToString function and clickhouse has implemented IPv6NumToString function, we can just delete it.
@ywqzzy ywqzzy added type/enhancement The issue or PR belongs to an enhancement. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Apr 13, 2022
@junaire junaire mentioned this issue Apr 28, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue May 5, 2022
@junaire
refactor: Remove unused FunctionIPv6NumToString from ClickHouse. (#4797)
fd367d4 
ref #4640
@ywqzzy ywqzzy mentioned this issue Sep 20, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Sep 21, 2022
@ywqzzy
*: Remove function higherOrder & ExternalModels & FindCluster (#5963)
007359f 
ref #4640
@ywqzzy ywqzzy mentioned this issue Sep 21, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Sep 22, 2022
@ywqzzy
*: Remove external models (#5978)
9e3e4fa 
ref #4640
@ywqzzy ywqzzy mentioned this issue Sep 22, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Sep 22, 2022
@ywqzzy
*: remove array functions. (#5987)
ad41d9d 
ref #4640
@ywqzzy ywqzzy mentioned this issue Oct 11, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Oct 12, 2022
@ywqzzy
*: remove VisitParam functions (#6106)
e2cde35 
ref #4640
@ywqzzy ywqzzy mentioned this issue Nov 3, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Nov 3, 2022
@ywqzzy
*: remove useless functions. (#6220)
54d1d94 
ref #4640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ywqzzy