Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supply comments #4862

Open
breezewish opened this issue May 11, 2022 · 0 comments
Open

Supply comments #4862

breezewish opened this issue May 11, 2022 · 0 comments
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@breezewish
Copy link
Member

Enhancement

We are now heavily relying on internal design docs. It is not friendly for the community to understand the code base. We should at least have comments for important functions, describing their usages.
@breezewish breezewish added the type/enhancement The issue or PR belongs to an enhancement. label May 11, 2022
@breezewish breezewish mentioned this issue May 11, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue May 13, 2022
@breezewish
misc: Add comments (#4863)
8bb0622 
ref #4862
@hongyunyan hongyunyan mentioned this issue Jun 13, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Jun 14, 2022
@hongyunyan
enhencement: supplement the comment for SchemaActionType (#5139)
bcb837b 
ref #4862
@JaySon-Huang JaySon-Huang mentioned this issue Jun 16, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Jun 18, 2022
@JaySon-Huang
*: Add some comments about decoding (#5158)
164eda5 
ref #4862
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@breezewish