Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background gc thread check interval is too short #5057

Closed
lidezhu opened this issue Jun 2, 2022 · 0 comments · Fixed by #5056
Closed

Background gc thread check interval is too short #5057

lidezhu opened this issue Jun 2, 2022 · 0 comments · Fixed by #5056
Assignees
@lidezhu
Labels
affects-5.0 affects-5.1 affects-5.2 affects-5.3 affects-5.4 affects-6.0 affects-6.1 component/storage severity/moderate type/bug The issue is confirmed as a bug.

Comments

@lidezhu
Copy link
Contributor

lidezhu commented Jun 2, 2022 •
edited
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

The current background gc check interval seems not optimal, as the following image shows, the background gc frequency is almost the same as fg_rpc type which is triggered by user manually.
image

This should consume some unnecessary resource since background gc is meant to reclaimed obsolete data. So we should increase the background gc thread check interval.
@lidezhu lidezhu added the type/enhancement The issue or PR belongs to an enhancement. label Jun 2, 2022
@lidezhu lidezhu mentioned this issue Jun 2, 2022
Merged
12 tasks
@lidezhu lidezhu self-assigned this Jun 2, 2022
ti-chi-bot pushed a commit that referenced this issue Jun 3, 2022
@lidezhu
increase bg gc check interval (#5056)
677ad75 
close #5057
This was referenced Jun 3, 2022
Merged
Closed
Merged
Merged
Merged
Closed
Merged
ti-chi-bot added a commit that referenced this issue Jun 14, 2022
@ti-chi-bot
increase bg gc check interval (#5056) (#5065)
35cc201 
close #5057
ti-chi-bot added a commit that referenced this issue Jun 21, 2022
@ti-chi-bot
increase bg gc check interval (#5056) (#5066)
d566261 
close #5057
ti-chi-bot added a commit that referenced this issue Jun 21, 2022
@ti-chi-bot
increase bg gc check interval (#5056) (#5062)
e49dcb0 
close #5057
ti-chi-bot added a commit that referenced this issue Jun 21, 2022
@ti-chi-bot
increase bg gc check interval (#5056) (#5064)
a8d9c66 
close #5057
ti-chi-bot added a commit that referenced this issue Jun 22, 2022
@ti-chi-bot
increase bg gc check interval (#5056) (#5068)
4896a3b 
close #5057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidezhu lidezhu

Labels
affects-5.0 affects-5.1 affects-5.2 affects-5.3 affects-5.4 affects-6.0 affects-6.1 component/storage severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

increase bg gc check interval lidezhu/tics
1 participant
@lidezhu