-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better RUNTIME_CHECK
and RUNTIME_ASSERT
#5444
Labels
type/enhancement
The issue or PR belongs to an enhancement.
Comments
12 tasks
ti-chi-bot
pushed a commit
that referenced
this issue
Jul 27, 2022
JaySon-Huang
pushed a commit
to ti-chi-bot/tiflash
that referenced
this issue
Aug 31, 2022
close pingcap#5444 Conflicts: dbms/src/Common/FailPoint.cpp dbms/src/Common/FailPoint.h dbms/src/Flash/Coprocessor/DAGQueryBlockInterpreter.cpp dbms/src/Flash/Mpp/ExchangeReceiver.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Enhancement
RUNTIME_CHECK
Current
RUNTIME_CHECK
usage is:It's not clear for users to know which exception will be thrown. A better way is to explicit write code for generating an exception object like:
And the new style could enable better compilation checks.
RUNTIME_ASSERT
Current
RUNTIME_ASSERT
always needs alogger
and make it hard for replacing existentassert
s. We should let it work without user provided logger (in which case a default logger is used).The text was updated successfully, but these errors were encountered: