Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve memtrack to reduce OOM cases #5609

Closed
bestwoody opened this issue Aug 11, 2022 · 0 comments · Fixed by #5610 or #5779
Closed

Improve memtrack to reduce OOM cases #5609

bestwoody opened this issue Aug 11, 2022 · 0 comments · Fixed by #5610 or #5779
Assignees
@bestwoody
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@bestwoody
Copy link
Contributor

bestwoody commented Aug 11, 2022 •
edited
Loading

Enhancement

There are some problems which may cause memory quota not working, so that more OOM cases.

  1. Some kind of object is not tracked, such as object generated by Protobuf.
  2. A bug in memtracker, which causes memory quota not working.
  3. Some bugs in our MPPTask construct/destruct logic, which causememtracker can‘t be propagated into MPPTunnel & ExchangeReceiver
  4. Some un-trackable memory such as: cache used by Allocator 、stack allocated by threads.
@bestwoody bestwoody added the type/enhancement The issue or PR belongs to an enhancement. label Aug 11, 2022
@bestwoody bestwoody mentioned this issue Aug 11, 2022
Merged
12 tasks
@bestwoody bestwoody self-assigned this Aug 12, 2022
@SeaRise SeaRise mentioned this issue Aug 24, 2022
Closed
ti-chi-bot pushed a commit that referenced this issue Aug 31, 2022
@bestwoody
Improve memtrack (#5610)
72f4951 
close #5609
@bestwoody bestwoody mentioned this issue Sep 3, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Sep 5, 2022
@bestwoody
Bugfix of memtracker released early (#5779)
073b958 
close #5609
@windtalker windtalker mentioned this issue Sep 26, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Sep 27, 2022
@windtalker
Refine the lifecycle of memory_tracker for MPP query (#6020)
3548744 
ref #5609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bestwoody bestwoody

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve memtrack bestwoody/tiflash
Bugfix of memtracker released early bestwoody/tiflash
1 participant
@bestwoody