Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join & Aggregation Fine Grained Partition Optimization #6157

Closed
6 tasks done
yibin87 opened this issue Oct 18, 2022 · 0 comments · Fixed by #6202
Closed
6 tasks done

Join & Aggregation Fine Grained Partition Optimization #6157

yibin87 opened this issue Oct 18, 2022 · 0 comments · Fixed by #6202
Assignees
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@yibin87
Copy link
Contributor

yibin87 commented Oct 18, 2022

Enhancement

This issue tracks Join&Aggregation operator utilizing fine grained partition tech to optimize its implementation.
For Join operator:
The time saved by utilizing fine grained partition tech in Prob side is much fewer than the cost brought by fine grained partition itself, so just consider optimize Build side. Besides, the optimization requires:

  1. Prob side uses the same (or compatible) hash function to choose build side stream, and uses original hash function to do the match work.
  2. The prehash key is the same as the Join hash table's hash key

For Agg operator:
Nothing special.

Related issue: #4631

TiDB

TiFlash

After apply all these optimizations, TPCH_100 3 nodes, 2-tiflash replica, total execution time will reduce about 10%, 80.6 => 72.3:
acbfac11-b14f-4347-b4a6-7cb3fc371e7f

@yibin87 yibin87 added the type/enhancement The issue or PR belongs to an enhancement. label Oct 18, 2022
@yibin87 yibin87 self-assigned this Oct 21, 2022
@yibin87 yibin87 reopened this Oct 31, 2022
@yibin87 yibin87 reopened this Nov 2, 2022
CalvinNeo pushed a commit to CalvinNeo/tiflash that referenced this issue Nov 4, 2022
close pingcap#6157

Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@yibin87 yibin87 closed this as completed Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant