Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpp_establish_conn related metrics is broken when enable async grpc server #6197

Closed
windtalker opened this issue Oct 27, 2022 · 0 comments · Fixed by #6203
Closed

mpp_establish_conn related metrics is broken when enable async grpc server #6197

windtalker opened this issue Oct 27, 2022 · 0 comments · Fixed by #6203

Comments

@windtalker
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

When enable async grpc server, mpp_establish_conn related metrics(mpp_establish_conn_duration, mpp_establish_conn_count) is broken because in

SCOPE_EXIT({
GET_METRIC(tiflash_coprocessor_handling_request_count, type_mpp_establish_conn).Decrement();
GET_METRIC(tiflash_coprocessor_request_duration_seconds, type_mpp_establish_conn).Observe(watch.elapsedSeconds());
// TODO: update the value of metric tiflash_coprocessor_response_bytes.
});

it is assumed that when AsyncFlashService::establishMPPConnectionAsync finishes, the establish connection also finishes. It is not true for async grpc server.

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiFlash version? (Required)

CalvinNeo pushed a commit to CalvinNeo/tiflash that referenced this issue Nov 4, 2022
close pingcap#6197

Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants