Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DiagnosticsService can not filter filename by datatime #6829

Closed
hongyunyan opened this issue Feb 15, 2023 · 2 comments · Fixed by #6838
Closed

DiagnosticsService can not filter filename by datatime #6829

hongyunyan opened this issue Feb 15, 2023 · 2 comments · Fixed by #6838
Labels
affects-5.4 affects-6.1 affects-6.5 component/storage severity/minor type/bug The issue is confirmed as a bug.

Comments

@hongyunyan
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. make a cluster up
  2. add a new log file like 'tiflash_tikv-2023-01-30T02-00-12.039.log' in tiflash/log
  3. do log search in dashboard with time selection

2. What did you expect to see? (Required)

we read the log match the time selection.

3. What did you see instead (Required)

we read all log files in tiflash/log(when there are quite a lot of log files , search will be very slow)
image

This problem is related to the code FilterFileByDatetime in LogSearch.cpp, the filter function is not appropriate with the log file's name now.

4. What is your TiFlash version? (Required)

nightly
@hongyunyan hongyunyan added the type/bug The issue is confirmed as a bug. label Feb 15, 2023
@hehechen
Copy link
Contributor

hehechen commented Feb 16, 2023 •
edited
Loading

It's because the format of TiKV log filename has been modified in tikv/tikv#11657

@hehechen
Copy link
Contributor

This bug was introduced in v5.4.
https://github.com/pingcap/tidb-engine-ext/blob/c15322fd615c518b0fa2d2204dbdf32dd0b4cfdf/components/server/src/setup.rs#L42

@hehechen hehechen mentioned this issue Feb 17, 2023
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Feb 20, 2023
@hehechen
fix proxy log search (#6838)
7eae316 
close #6829
This was referenced Feb 20, 2023
Closed
Merged
Merged
ti-chi-bot added a commit that referenced this issue Feb 25, 2023
@ti-chi-bot
fix proxy log search (#6838) (#6860)
bd5afaa 
close #6829
ti-chi-bot added a commit that referenced this issue Mar 30, 2023
@ti-chi-bot
fix proxy log search (#6838) (#6859)
6117427 
close #6829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.4 affects-6.1 affects-6.5 component/storage severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix proxy log search hehechen/tics
3 participants
@jebter @hehechen @hongyunyan