Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unstable unit test ComputeServerRunner.multipleQuery #8264

Closed
JaySon-Huang opened this issue Oct 27, 2023 · 2 comments · Fixed by #8621
Closed

unstable unit test ComputeServerRunner.multipleQuery #8264

JaySon-Huang opened this issue Oct 27, 2023 · 2 comments · Fixed by #8621
Labels
component/compute severity/major type/bug The issue is confirmed as a bug.

Comments

@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Oct 27, 2023

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

All unit test passed

3. What did you see instead (Required)

ComputeServerRunner.multipleQuery is not stable

https://ci.pingcap.net/blue/organizations/jenkins/tiflash-ghpr-unit-tests/detail/tiflash-ghpr-unit-tests/11643/pipeline

[2023-10-27T02:57:51.755Z] /home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Flash/tests/gtest_compute_server.cpp:742: Failure
[2023-10-27T02:57:51.755Z] Value of: assertQueryActive(gather_id.query_id)
[2023-10-27T02:57:51.755Z]   Actual: false (Query <query_ts:0, local_query_id:11, server_id:1, start_ts:11, resource_group: >not active
[2023-10-27T02:57:51.755Z] )
[2023-10-27T02:57:51.755Z] Expected: true

https://ci.pingcap.net/blue/organizations/jenkins/tiflash-ghpr-unit-tests/detail/tiflash-ghpr-unit-tests/11645/pipeline/
https://ci.pingcap.net/blue/rest/organizations/jenkins/pipelines/tiflash-ghpr-unit-tests/runs/11645/nodes/75/steps/80/log/?start=0

[2023-10-27T05:26:11.026Z] /home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Flash/tests/gtest_compute_server.cpp:742: Failure
[2023-10-27T05:26:11.026Z] Value of: assertQueryActive(gather_id.query_id)
[2023-10-27T05:26:11.026Z]   Actual: false (Query <query_ts:0, local_query_id:12, server_id:1, start_ts:12, resource_group: >not active
[2023-10-27T05:26:11.026Z] )
[2023-10-27T05:26:11.026Z] Expected: true

4. What is your TiFlash version? (Required)

test running with this PR: #8248

@SeaRise
Copy link
Contributor

SeaRise commented Oct 31, 2023

image
It seems that the query ends before canceling.
But it is not as expected, because before cancel, mock scan will continue to output block...

@xzhangxian1008
Copy link
Contributor

image
It seems that the query ends because of timeout. And I think the timeout is caused by heavy system load. Not a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/compute severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants