Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce rapidjson or simdjson? #8371

Closed
SeaRise opened this issue Nov 14, 2023 · 1 comment · Fixed by #8333
Closed

Introduce rapidjson or simdjson? #8371

SeaRise opened this issue Nov 14, 2023 · 1 comment · Fixed by #8333
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@SeaRise
Copy link
Contributor

SeaRise commented Nov 14, 2023 •
edited
Loading

Enhancement

POCO::JSON behaves differently from golang::json and does not support passing StringRef, resulting in poor performance. Perhaps we could consider introducing rapidjson or simdjson and implementing JSON-related functions based on it. #8307

https://github.com/Tencent/rapidjson
https://github.com/simdjson/simdjson
ps: simdjson require AVX2

clickhouse: https://github.com/ClickHouse/ClickHouse/blob/80ca41f18ddcd92eb70533d43b3d2f3d2be93364/src/Common/JSONParsers/RapidJSONParser.h#L16
https://github.com/ClickHouse/ClickHouse/blob/80ca41f18ddcd92eb70533d43b3d2f3d2be93364/src/Common/JSONParsers/SimdJSONParser.h
@SeaRise SeaRise added the type/enhancement The issue or PR belongs to an enhancement. label Nov 14, 2023
@SeaRise SeaRise changed the title Introduce rapidjson? Introduce rapidjson/simdjson? Nov 14, 2023
@SeaRise SeaRise changed the title Introduce rapidjson/simdjson? Introduce rapidjson or simdjson? Nov 14, 2023
This was referenced Nov 15, 2023
Closed
Merged
@SeaRise
Copy link
Contributor Author

SeaRise commented Nov 15, 2023

https://simdjson.org/
8322fce0-8b3b-415d-bb22-40b217b17b64

ti-chi-bot bot pushed a commit that referenced this issue Nov 27, 2023
@SeaRise
support cast as json (#8333)
d1b149e 
close #8307, close #8371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support cast as json SeaRise/tiflash
WIP: introduce simdjson SeaRise/tiflash
1 participant
@SeaRise