Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agg final spill event should be added if have spill data #9022

Closed
gengliqi opened this issue May 7, 2024 · 0 comments · Fixed by #9023
Closed

Agg final spill event should be added if have spill data #9022

gengliqi opened this issue May 7, 2024 · 0 comments · Fixed by #9023
Labels
component/compute severity/major type/bug The issue is confirmed as a bug.

Comments

@gengliqi
Copy link
Contributor

gengliqi commented May 7, 2024

Bug Report

#8957 introduced a bug that AggregateFinalSpillEvent may not be added if have spill data which may cause wrong agg result.
@gengliqi gengliqi added the type/bug The issue is confirmed as a bug. label May 7, 2024
@gengliqi gengliqi changed the title Agg Final spill event should be added if have spill data Agg final spill event should be added if have spill data May 7, 2024
@gengliqi gengliqi mentioned this issue May 7, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot closed this as completed in #9023 May 8, 2024
ti-chi-bot bot pushed a commit that referenced this issue May 8, 2024
@gengliqi
Add agg final spill event if have spill data (#9023)
db0bfc9 
close #9022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/compute severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add agg final spill event if have spill data gengliqi/tiflash
2 participants
@jebter @gengliqi