Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParallelPrehandle: executeParallelTransform could return Aborted if there is ErrUpdateSchema (release-7.5) #9405

Open
CalvinNeo opened this issue Sep 3, 2024 · 4 comments

Comments

@CalvinNeo
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiFlash version? (Required)

@CalvinNeo CalvinNeo added the type/bug The issue is confirmed as a bug. label Sep 3, 2024
@JaySon-Huang
Copy link
Contributor

@CalvinNeo Can you add more description about this issue?

@CalvinNeo
Copy link
Member Author

In master,

res = ReadFromStreamResult{.error = abort_reason.value(), .extra_msg = "", .region = new_region};
will replicate reason when abort.

However, release-7.5 will not.

So if the result is errupdateschema and aborted, and aborted is handled the first, then prehandle will not retry

@CalvinNeo
Copy link
Member Author

In 7.5, parallel prehandle is not enabled, so the severity is moderate.

@CalvinNeo
Copy link
Member Author

See #8246

@CalvinNeo CalvinNeo changed the title ParallelPrehandle: executeParallelTransform could return Aborted if there is ErrUpdateSchema ParallelPrehandle: executeParallelTransform could return Aborted if there is ErrUpdateSchema (release-7.5) Sep 24, 2024
ti-chi-bot bot pushed a commit that referenced this issue Sep 25, 2024
close #9405

Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>

Co-authored-by: Purelind <purelind@users.noreply.github.com>
Co-authored-by: JaySon <tshent@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants