fix decimal bug #10
Closed
fix decimal bug #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-integration-tests |
zanmato1984
reviewed
Mar 12, 2019
| @@ -44,6 +44,16 @@ class AggregateFunctionAvg final : public IAggregateFunctionDataHelper<Aggregate | |||
| } | |||
| String getName() const override { return "avg"; } | |||
|
|
|||
| AggregateDataPtr adjust_place(AggregateDataPtr place) const { | |||
There was a problem hiding this comment.
These two functions are implemented twice, in both avg and sum. They can simply be static and put somewhere common.
zanmato1984
reviewed
Mar 12, 2019
| @@ -44,6 +44,16 @@ class AggregateFunctionAvg final : public IAggregateFunctionDataHelper<Aggregate | |||
| } | |||
| String getName() const override { return "avg"; } | |||
|
|
|||
| AggregateDataPtr adjust_place(AggregateDataPtr place) const { | |||
There was a problem hiding this comment.
I recommend to name these two functions more specifically as alignDecimalPlace, put more comments, and use the camel-case naming as CH does (i.e. alignDecimalPlace rather than align_decimal_place).
|
Don't merge to raft, merge to master instead: |
|
/rebuild |
|
Fixed in #51 |
12 tasks
JinheLin
pushed a commit
to JinheLin/tiflash-1
that referenced
this pull request
Apr 17, 2024
Refine some code: use template specialization to avoid too many compilation conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.