Fix mpp hang error if some error happens during compile of mpp plan in TiFlash #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
tisonkun
reviewed
Mar 11, 2021
dbms/src/Flash/Mpp/MPPHandler.h
Outdated
| } | ||
| catch (...) | ||
| { | ||
| LOG_WARNING(log, "Failed to finish all tunnels"); |
There was a problem hiding this comment.
We could leverage the follow method for logging the exception either. Otherwise we know only it failed but lost the reason.
dbms/src/Flash/Mpp/MPPHandler.cpp
Outdated
| } | ||
| catch (...) | ||
| { | ||
| LOG_ERROR(log, "Fail to handle error in while trying to handle error and clean task"); |
leiysky
approved these changes
Mar 11, 2021
dbms/src/Flash/Mpp/MPPHandler.h
Outdated
| /// root task. Because for root task, if DispatchMPPTask fails, TiDB does | ||
| /// not sending establish MPP connection request at all, it is meaningless | ||
| /// to check the connect status in this case, just finish the tunnel. | ||
| void finish() |
There was a problem hiding this comment.
What about use a more critical word like destroy?
There was a problem hiding this comment.
OK, I will use close
dbms/src/Flash/Mpp/MPPHandler.h
Outdated
| @@ -279,6 +291,20 @@ struct MPPTask : std::enable_shared_from_this<MPPTask>, private boost::noncopyab | |||
|
|
|||
| void cancel(); | |||
|
|
|||
| void finishAllTunnel() | |||
|
/run-all-tests |
2 similar comments
|
/run-all-tests |
|
/run-all-tests |
ti-srebot
approved these changes
Mar 11, 2021
windtalker
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #1529
Problem Summary:
As the issue described.
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
The root cause is if a mpp task failed in
DispatchMPPTaskstage, TiFlash does not handle the error properly, which makes the query hangs. In this pr, error handle logical is added.Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note