Support enum type in mpp mode. #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
3 similar comments
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
hanfei1991
approved these changes
Mar 13, 2021
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@windtalker merge failed. |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #1489
Problem Summary:
As the issue desribed.
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
The root cause is the
tipb::FieldTypedoes not containselemswhich stores some meta data forEnumorSettype, without this meta data, TiFlash could not construct theEnumtype inExchangeReceiver, so it wil throw Exception when there areEnumtype data in MPP query. In pingcap/tipb#217, it addselemsfield totipb::FieldType, which make it possible to supportEnumtype in MPP, a tidb pr is already in flight, and this pr is to supportEnumtype in MPP in TiFlash side.Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note