Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong return value of timestamp column if the timestamp value is 1970-01-01 and the timezone offset is negative (#1577) #1601

Merged
merged 4 commits into from
Apr 7, 2021

Conversation

ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Mar 20, 2021

cherry-pick #1577 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/1601

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tics.git pr/1601:release-4.0-be6ccc9bf61d

What problem does this PR solve?

Issue Number: close #1572

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

The root cause is Clickhouse's DateLUT only support time starting from 1970-01-01, and in some corner case, the actual time may be 1969-12-31, this pr handle this special case separately

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Fix wrong return value of timestamp column if the timestamp value is 1970-01-01 and the timezone offset is negative

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@JaySon-Huang JaySon-Huang modified the milestones: v4.0.12, v4.0.13 Apr 2, 2021
@windtalker
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2021
@ti-srebot
Copy link
Collaborator Author

/run-all-tests

@ti-srebot
Copy link
Collaborator Author

@ti-srebot merge failed.

@windtalker
Copy link
Contributor

/run-all-tests

@windtalker windtalker merged commit b88d930 into pingcap:release-4.0 Apr 7, 2021
@windtalker windtalker deleted the release-4.0-be6ccc9bf61d branch April 7, 2021 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHERRY-PICK cherry pick status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants