Fix wrong return value of timestamp column if the timestamp value is 1970-01-01
and the timezone offset is negative (#1577)
#1601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1577 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tics repo: git pr https://github.com/pingcap/tics/pull/1601
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #1572
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
The root cause is Clickhouse's
DateLUT
only support time starting from1970-01-01
, and in some corner case, the actual time may be1969-12-31
, this pr handle this special case separatelyRelated changes
Check List
Tests
Side effects
Release note
1970-01-01
and the timezone offset is negative