Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update client-c to fix successive StoreNotMatch error #1713

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Update client-c to fix successive StoreNotMatch error #1713

merged 1 commit into from
Mar 31, 2021

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Mar 31, 2021 •
edited by solotzg
Loading

What problem does this PR solve?

close #1717

Problem Summary:
See pingcap/tidb#22909

What is changed and how it works?

What's Changed:

Related changes

  • Need to cherry-pick to the release branch:

Check List

Tests

  • No code

Release note

  • No release note

@leiysky leiysky added type/bugfix This PR fixes a bug. needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 labels Mar 31, 2021
@leiysky
Copy link
Contributor Author

leiysky commented Mar 31, 2021

/cc @solotzg @hanfei1991

solotzg
solotzg approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@solotzg solotzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 31, 2021
@leiysky
Copy link
Contributor Author

leiysky commented Mar 31, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 31, 2021
@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot ti-srebot merged commit 6bcd6e1 into pingcap:master Mar 31, 2021
@ti-srebot ti-srebot mentioned this pull request Mar 31, 2021
Merged
@ti-srebot
Copy link
Collaborator

cherry pick to release-5.0 in PR #1714

@JaySon-Huang JaySon-Huang deleted the fix/store-not-match branch March 31, 2021 15:50
@solotzg
Copy link
Contributor

solotzg commented Mar 31, 2021

Shall we fix such problem for 4.0？

@leiysky leiysky mentioned this pull request Apr 1, 2021
Merged
@solotzg solotzg linked an issue Apr 1, 2021 that may be closed by this pull request
client-c can not deal with StoreNotMatch correctly #1717
Closed
ti-srebot pushed a commit that referenced this pull request Apr 3, 2021
@leiysky
Update client-c to fix successive StoreNotMatch error (#1713) (#1716)
169556f
ti-srebot added a commit that referenced this pull request Apr 9, 2021
@ti-srebot
Update client-c to fix successive StoreNotMatch error (#1713) (#1714)
f626917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solotzg solotzg solotzg approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

client-c can not deal with StoreNotMatch correctly
3 participants
@leiysky @ti-srebot @solotzg