Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use file path as cache key (#1852) #1861

Merged
merged 4 commits into from
May 12, 2021

Conversation

ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented May 6, 2021

cherry-pick #1852 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/1861

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tics.git pr/1861:release-4.0-7bb9a84fe7f2

What problem does this PR solve?

Issue Number: close #1352

Problem Summary:

What is changed and how it works?

What's Changed:

Use file path as cache key instead of a 128 bits hash code.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. labels May 6, 2021
@ti-srebot ti-srebot added this to the v4.0.13 milestone May 6, 2021
@JaySon-Huang
Copy link
Contributor

Mark those hash_salt unused or delete them at all as #1866 does. And resolve the conflicts.

@JinheLin
Copy link
Contributor

JinheLin commented May 7, 2021

/run-all-tests

Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaySon-Huang JaySon-Huang merged commit 9608991 into pingcap:release-4.0 May 12, 2021
@JaySon-Huang JaySon-Huang deleted the release-4.0-7bb9a84fe7f2 branch May 12, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants