invalidate stale regions for Mpp query. (#1859) #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot
added
CHERRY-PICK
|
Should use the release-5.0 branch of kvproto |
|
/merge |
|
@hanfei1991 Oops! This PR requires at least 1 LGTMs to merge. The current number of |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1859 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tics repo: git pr https://github.com/pingcap/tics/pull/1877After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Problem Summary:
Right now, we won't update the stale regions during executing Mpp queries. Then we added the try regions field in MppDispatchTask reponse and try to invalidate the stale regions on TiDB side.
What is changed and how it works?
Related changes
pingcap/kvproto#751
Check List
Tests
["DAGQueryBlockInterpreter: Start to retry 1 regions (10936,)"]["invalid region because tiflash detected stale region"] ["region id"="{ region id: 10936, ver: 116, confVer: 2 }"]proving this function works.Release note