Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cast int as time (#1788) #1892

Merged
merged 2 commits into from
Jul 7, 2021

Conversation

ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented May 12, 2021

cherry-pick #1788 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/1892

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tics.git pr/1892:release-4.0-c1e77824e6db

Signed-off-by: Yu Lei leiysky@outlook.com

What problem does this PR solve?

Issue Number: close #1764

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Fix the issue that cast int as time function in TiFlash's coprocessor may produce wrong result

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 12, 2021
@ti-srebot ti-srebot added CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. labels May 12, 2021
@ti-srebot ti-srebot added this to the v4.0.13 milestone May 12, 2021
@JaySon-Huang JaySon-Huang modified the milestones: v4.0.13, v4.0.14 May 28, 2021
@leiysky
Copy link
Contributor

leiysky commented Jul 7, 2021

/merge

@ti-srebot
Copy link
Collaborator Author

@leiysky Oops! This PR requires at least 1 LGTMs to merge. The current number of LGTM is 0

@leiysky
Copy link
Contributor

leiysky commented Jul 7, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 7, 2021
@ti-srebot
Copy link
Collaborator Author

Your auto merge job has been accepted, waiting for:

  • 1914

@ti-srebot
Copy link
Collaborator Author

/run-all-tests

@ti-srebot ti-srebot merged commit 3e1dd3c into pingcap:release-4.0 Jul 7, 2021
@leiysky leiysky deleted the release-4.0-c1e77824e6db branch July 7, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHERRY-PICK cherry pick status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants