Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write I/O rate limit for background and foreground write request. #2184

Merged
merged 11 commits into from
Jun 21, 2021
Merged

Write I/O rate limit for background and foreground write request. #2184

merged 11 commits into from
Jun 21, 2021

Conversation

JinheLin
Copy link
Contributor

What problem does this PR solve?

Problem Summary:

This PR is a sub-task of issue: #1720. It implements configurable I/O rate limit for background and foreground write request.

What is changed and how it works?

Proposal: TiFlash IO Rate Limiter

New Configurations:

  • storage.io-rate-limit.max-bytes-per-sec = 0
  • storage.io-rate-limit.mode = write-only
  • By default, max-bytes-per-sec is 0 and I/O rate limit is disabled.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

  • Make I/O rate limiter more comprehensive.

Set storage.io-rate-limit.max-bytes-per-sec = 12582912(12 MB) :
image

@JinheLin
Copy link
Contributor Author

/run-all-tests

@JinheLin
Copy link
Contributor Author

/build

JaySon-Huang
JaySon-Huang reviewed Jun 17, 2021
View reviewed changes
dbms/src/Server/StorageConfigParser.h Outdated Show resolved Hide resolved
dbms/src/Encryption/RateLimiter.h Outdated Show resolved Hide resolved
dbms/src/Server/StorageConfigParser.cpp Show resolved Hide resolved
dbms/src/Storages/DeltaMerge/Delta/CompactDelta.cpp Outdated Show resolved Hide resolved
@JinheLin
Copy link
Contributor Author

/run-all-tests

lidezhu
lidezhu reviewed Jun 18, 2021
View reviewed changes
dbms/src/Interpreters/Context.h Outdated Show resolved Hide resolved
dbms/src/Interpreters/Context.h Outdated Show resolved Hide resolved
dbms/src/Encryption/RateLimiter.h Outdated Show resolved Hide resolved
dbms/src/Encryption/RateLimiter.cpp Outdated Show resolved Hide resolved
lidezhu
lidezhu approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@lidezhu lidezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 18, 2021
@JinheLin
Copy link
Contributor Author

/run-all-tests

@JinheLin
Copy link
Contributor Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 21, 2021
@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot ti-srebot merged commit f3b4b75 into pingcap:master Jun 21, 2021
@JaySon-Huang JaySon-Huang mentioned this pull request Jun 23, 2021
Merged
@windtalker windtalker mentioned this pull request Jun 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidezhu lidezhu lidezhu approved these changes

@JaySon-Huang JaySon-Huang Awaiting requested review from JaySon-Huang

@flowbehappy flowbehappy Awaiting requested review from flowbehappy

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JinheLin @ti-srebot @JaySon-Huang @lidezhu