Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine some include headers & add option ENABLE_FAILPOINTS (#2296) #2479

Merged

Conversation

ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Jul 23, 2021

cherry-pick #2296 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/2479

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tics.git pr/2479:release-5.1-9d51ac4e0c64

What problem does this PR solve?

Issue Number: related to #2295

What is changed and how it works?

  • Only include these files when need:
    • <Common/Config/cpptoml.h>
    • <tipb/select.pb.h> in <Interpreters/TimezoneInfo.h>
    • <Flash/Coprocessor/DAGContext.h> in <Interpreters/Context.h>
  • Add "ENABLE_FAILPOINTS" so that we can build a release binary with failpoint enabled with
    cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DENABLE_TESTS=OFF -DENABLE_FAILPOINTS=ON ..

This can remove dependency for some targets (page_storage for example) and make it easier to write and run unit tests.

Related changes

Check List

Tests

  • No code

Side effects

Release note

  • No release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. labels Jul 23, 2021
@ti-srebot ti-srebot added this to the v5.1.1 milestone Jul 23, 2021
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Copy link
Contributor

/run-all-tests

@JaySon-Huang
Copy link
Contributor

/run-all-tests

@JaySon-Huang JaySon-Huang merged commit 0ac962a into pingcap:release-5.1 Aug 3, 2021
@JaySon-Huang JaySon-Huang deleted the release-5.1-9d51ac4e0c64 branch August 3, 2021 07:14
@JaySon-Huang JaySon-Huang modified the milestones: v5.1.1, v5.1.2 Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants