[FLASH-549/550/626] Remove obsoleted data in Engine DeltaMerge #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JaySon-Huang
commented
Oct 23, 2019
•
JaySon-Huang
commented
- Update GC safe point to remove obsoleted data when doing Segment split / merge / delta-merge.
- When region removed, write a deleteRange to Engine DeltaMerge for deleting obsoleted data.
flowbehappy
reviewed
Oct 28, 2019
flowbehappy
reviewed
Oct 28, 2019
| @@ -225,8 +225,6 @@ class DeltaMergeStore : private boost::noncopyable | |||
|
|
|||
| Settings settings; | |||
|
|
|||
| UInt64 min_version = 0; | |||
There was a problem hiding this comment.
We should keep this value here, and use a min_version_last_upate_time to prevent frequently update this value.
There was a problem hiding this comment.
Ok.
And I add dm_safe_point_update_interval_seconds in Settings with default 60 seconds (which is the same interval of TiKV)
JaySon-Huang
commented
Oct 29, 2019
JaySon-Huang
force-pushed
the
dm-remove-obsoleted-data
branch
from
5d16c9a to
72155c7
Compare
|
/run-integration-tests |
2 similar comments
|
/run-integration-tests |
|
/run-integration-tests |
JaySon-Huang
force-pushed
the
dm-remove-obsoleted-data
branch
5 times, most recently
from
8cd9c93 to
4e99b57
Compare
|
/rebuild |
1 similar comment
|
/rebuild |
JaySon-Huang
force-pushed
the
dm-remove-obsoleted-data
branch
from
4e99b57 to
766a9f9
Compare
JaySon-Huang
commented
Oct 31, 2019
JaySon-Huang
changed the title
JaySon-Huang
force-pushed
the
dm-remove-obsoleted-data
branch
from
766a9f9 to
a8bdbd7
Compare
JaySon-Huang
changed the title
JaySon-Huang
force-pushed
the
dm-remove-obsoleted-data
branch
from
a8bdbd7 to
54c51ec
Compare
JaySon-Huang
force-pushed
the
DeltaMergeEngine
branch
from
7257e74 to
d6e8b20
Compare
JaySon-Huang
force-pushed
the
dm-remove-obsoleted-data
branch
from
54c51ec to
5e9b62f
Compare
|
LGTM |
12 tasks
CalvinNeo
pushed a commit
to CalvinNeo/tiflash
that referenced
this pull request
Sep 23, 2024
Signed-off-by: Wish <breezewish@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.