Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception of sched_setaffinity. #3126

Merged
merged 2 commits into from
Sep 22, 2021
Merged

Fix exception of sched_setaffinity. #3126

merged 2 commits into from
Sep 22, 2021

Conversation

JinheLin
Copy link
Contributor

@JinheLin JinheLin commented Sep 22, 2021

What problem does this PR solve?

Issue Number: close #3106

What is changed and how it works?

Proposal: xxx

What's Changed:

sched_setaffinity may returns error when threads exit concurrently.

Don't throw exeception when sched_setaffinity returns error and just log a message.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

none

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 22, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 22, 2021
@solotzg
Copy link
Contributor

solotzg commented Sep 22, 2021

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 22, 2021
@flowbehappy flowbehappy self-requested a review September 22, 2021 04:10
Copy link
Contributor

@flowbehappy flowbehappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 22, 2021
@JinheLin
Copy link
Contributor Author

@JinheLin JinheLin merged commit f4ec9ec into pingcap:hotfix-5.1.1-patch1 Sep 22, 2021
@JaySon-Huang
Copy link
Contributor

/cherry-pick-master

@JaySon-Huang JaySon-Huang deleted the fix-exception branch September 23, 2021 03:15
@JaySon-Huang
Copy link
Contributor

/cherrypick master

@ti-chi-bot
Copy link
Member

@JaySon-Huang: new pull request created: #3133.

In response to this:

/cherrypick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 23, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants