-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exception of sched_setaffinity. #3126
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Can we catch all exceptions thrown from https://github.com/pingcap/tics/blob/275fa1bc48a9953e828db3100f3086a553d1255b/dbms/src/Server/Server.cpp#L1260-L1262 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yes. |
/cherry-pick-master |
/cherrypick master |
@JaySon-Huang: new pull request created: #3133. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #3106
What is changed and how it works?
Proposal: xxx
What's Changed:
sched_setaffinity
may returns error when threads exit concurrently.Don't throw exeception when
sched_setaffinity
returns error and just log a message.Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note