-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PageStorage MVCC refine : removed VersionSet and VersionSetWithDelta header file #3422
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-unit-test |
Signed-off-by: JaySon-Huang <tshent@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some changes and add gtest_page_entry_map.cpp
back.
And I think we can also merge Storages/Page/mvcc/VersionSetWithDelta.h
into Storages/Page/V2/VersionSet/PageEntriesVersionSetWithDelta.h
https://github.com/pingcap/tics/blob/1a319c21b2df5eba7568ace6c26f73f18dfba87f/dbms/src/Storages/Page/mvcc/VersionSetWithDelta.h#L125-L137
done. moved |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…Delta.h Co-authored-by: JaySon <jayson.hjs@gmail.com>
/merge |
@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: cb2841d
|
What problem does this PR solve?
Issue Number: close #3411
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
Page/mvcc/VersionSetWithDelta
(only one sub class used) and delete the VersionSet(no more used)Page/mvcc
intoPage/V2/mvcc/PageEntriesVersionSetWithDelta.h
as a hard logic.Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note