Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential data inconsistency when widen pk column type if pk is handle #3568

Merged
merged 3 commits into from
Dec 1, 2021
Merged

Fix potential data inconsistency when widen pk column type if pk is handle #3568

merged 3 commits into from
Dec 1, 2021

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Dec 1, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #3569

What is changed and how it works?

Check whether pk value overflow after insert.

Check List

Tests

  • Integration test

Release note

Fix potential data inconsistency when widen pk column type if pk is handle

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 1, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 1, 2021
@lidezhu lidezhu changed the title Fix potential data loss when widen pk if pk is handle Fix potential data inconsistency when widen pk if pk is handle Dec 1, 2021
@lidezhu lidezhu self-assigned this Dec 1, 2021
@lidezhu
Copy link
Contributor Author

lidezhu commented Dec 1, 2021

/run-all-tests

@lidezhu lidezhu added needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 labels Dec 1, 2021
@sre-bot
Copy link
Collaborator

sre-bot commented Dec 1, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/220/cobertura/
(Coverage detail url is limited office network access)

lines: 37.6% (44487 out of 118434)
branches: 5.5% (67250 out of 1215361)

flowbehappy
flowbehappy approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@flowbehappy flowbehappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 1, 2021
@lidezhu
Copy link
Contributor Author

lidezhu commented Dec 1, 2021

/merge

@ti-chi-bot
Copy link
Member

@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6d3fcb1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 1, 2021
@lidezhu lidezhu changed the title Fix potential data inconsistency when widen pk if pk is handle Fix potential data inconsistency when widen pk column type if pk is handle Dec 1, 2021
@sre-bot
Copy link
Collaborator

sre-bot commented Dec 1, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/223/cobertura/
(Coverage detail url is limited office network access)

lines: 37.5% (44400 out of 118434)
branches: 5.5% (67142 out of 1215361)

@lidezhu
Copy link
Contributor Author

lidezhu commented Dec 1, 2021

/merge

@ti-chi-bot
Copy link
Member

@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@lidezhu: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Dec 1, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/226/cobertura/
(Coverage detail url is limited office network access)

lines: 40.3% (44392 out of 110053)
branches: 5.6% (67102 out of 1197800)

@JaySon-Huang JaySon-Huang merged commit 830c106 into pingcap:master Dec 1, 2021
@JaySon-Huang JaySon-Huang deleted the fix-widen-pk branch December 1, 2021 06:35
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 1, 2021
Merged
1 task
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3570.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Dec 1, 2021
@lidezhu @ti-chi-bot
This is an automated cherry-pick of pingcap#3568
3e9fdb7 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 1, 2021
Closed
1 task
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3571.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3572.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 1, 2021
Merged
1 task
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3573.

This was referenced Dec 1, 2021
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3574.

ti-chi-bot added a commit that referenced this pull request Dec 17, 2021
@ti-chi-bot
Fix potential data inconsistency when widen pk column type if pk is h…
b67db4d 
…andle (#3568) (#3572)
ti-chi-bot added a commit that referenced this pull request Jan 24, 2022
@ti-chi-bot
Fix potential data inconsistency when widen pk column type if pk is h…
c52a7e2 
…andle (#3568) (#3573)
ti-chi-bot added a commit that referenced this pull request Feb 21, 2022
@ti-chi-bot
Fix potential data inconsistency when widen pk column type if pk is h…
6209208 
…andle (#3568) (#3570)
lidezhu added a commit that referenced this pull request Apr 12, 2022
@ti-chi-bot @lidezhu
Fix potential data inconsistency when widen pk column type if pk is h…
00f52be 
…andle (#3568) (#3574)

* Fix potential data loss when widen pk when pk is handle

* add widen_pk.test

Co-authored-by: lidezhu <lidezhu@pingcap.com>
Co-authored-by: lidezhu <47731263+lidezhu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

@windtalker windtalker Awaiting requested review from windtalker

Assignees

@lidezhu lidezhu

Labels
needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data may loss when widen pk if pk is handle
5 participants
@lidezhu @ti-chi-bot @sre-bot @flowbehappy @JaySon-Huang