Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unittests for str_to_date, fix #3556, #3557 (#3581) #3935

Merged
merged 6 commits into from
Jun 20, 2022
Merged

Add unittests for str_to_date, fix #3556, #3557 (#3581) #3935

merged 6 commits into from
Jun 20, 2022

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jan 24, 2022 •
edited by JaySon-Huang
Loading

This is an automated cherry-pick of #3581

What problem does this PR solve?

Issue Number: close #3557

close #3556

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix str_to_date() function incorrectly handles leading zeros when parsing Microseconds

@wshwsh12 @ti-chi-bot
This is an automated cherry-pick of pingcap#3581
0394219 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jan 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 24, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-5.0 labels Jan 24, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jan 24, 2022
@JaySon-Huang JaySon-Huang added this to the v5.0.7 milestone Jan 27, 2022
@CLAassistant
Copy link

CLAassistant commented Apr 2, 2022 •
edited by sre-bot
Loading

CLA assistant check
All committers have signed the CLA.

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 15, 2022
@windtalker
resolve conflict
1855319 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@windtalker
fix
1987b7f 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@windtalker
resolve conflict
1d3155b 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@windtalker
fix build
7f9a81f 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@windtalker
Copy link
Contributor

/rebuild

@windtalker
fix bulid
ed6ee8a 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 20, 2022
windtalker
windtalker approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 20, 2022
@windtalker
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: ed6ee8a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 20, 2022
@ti-chi-bot ti-chi-bot merged commit 4348cb9 into pingcap:release-5.0 Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@windtalker windtalker windtalker approved these changes

Assignees

@wshwsh12 wshwsh12

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.0
Projects
None yet
Milestone
v5.0.7
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-chi-bot @CLAassistant @windtalker @JaySon-Huang @VelocityLight @wshwsh12