Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some tests to test PageStorageV3 IO limiter #4094

Merged
merged 13 commits into from
May 6, 2022
Merged

Add some tests to test PageStorageV3 IO limiter #4094

merged 13 commits into from
May 6, 2022

Conversation

jiaqizho
Copy link
Contributor

@jiaqizho jiaqizho commented Feb 22, 2022 •
edited
Loading

Signed-off-by: jiaqizho zhoujiaqi@pingcap.com

What problem does this PR solve?

Issue Number: ref #3594

Problem Summary:

What is changed and how it works?

  • add some tests to test IO limiter in PageStorage V3

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@jiaqizho
Add some tests to test PageStorageV3 io limiter
4dd6fdc 
Signed-off-by: jiaqizho <zhoujiaqi@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CalvinNeo
  • flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-linked-issue size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 22, 2022
@jiaqizho
Copy link
Contributor Author

/run-all-tests

@jiaqizho
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 3, 2022
@jiaqizho jiaqizho mentioned this pull request Mar 3, 2022
Closed
76 tasks
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2022
@flowbehappy flowbehappy self-requested a review April 29, 2022 04:12
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. and removed do-not-merge/needs-linked-issue labels Apr 29, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 29, 2022
@jiaqizho
Copy link
Contributor Author

/run-all-tests

1 similar comment
@jiaqizho
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2022
@jiaqizho jiaqizho requested a review from CalvinNeo May 6, 2022 04:22
CalvinNeo
CalvinNeo approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 6, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 6, 2022
@jiaqizho
Copy link
Contributor Author

jiaqizho commented May 6, 2022

/run-all-tests

@jiaqizho
Copy link
Contributor Author

jiaqizho commented May 6, 2022

/rebuild

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2022
@jiaqizho
Copy link
Contributor Author

jiaqizho commented May 6, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented May 6, 2022

Coverage for changed files

Filename                                          Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Encryption/RateLimiter.h                               68                 2    97.06%          28                 2    92.86%          97                20    79.38%          32                 6    81.25%
Storages/Page/V3/tests/gtest_blob_store.cpp          4187               714    82.95%          24                 0   100.00%         987                 7    99.29%        1320               616    53.33%
Storages/Page/V3/tests/gtest_page_storage.cpp        3398              1188    65.04%          42                 7    83.33%        1008               154    84.72%        1080               615    43.06%
TestUtils/MockReadLimiter.h                             2                 0   100.00%           2                 0   100.00%           5                 0   100.00%           0                 0         -
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                7655              1904    75.13%          96                 9    90.62%        2097               181    91.37%        2432              1237    49.14%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18088      10150            43.89%    200820  100966       49.72%

full coverage report (for internal network access only)

@jiaqizho
Copy link
Contributor Author

jiaqizho commented May 6, 2022

/merge

@ti-chi-bot
Copy link
Member

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6f8231c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 6, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented May 6, 2022

Coverage for changed files

Filename                                          Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Encryption/RateLimiter.h                               68                 2    97.06%          28                 2    92.86%          97                20    79.38%          32                 6    81.25%
Storages/Page/V3/tests/gtest_blob_store.cpp          4187               714    82.95%          24                 0   100.00%         987                 7    99.29%        1320               616    53.33%
Storages/Page/V3/tests/gtest_page_storage.cpp        3398              1188    65.04%          42                 7    83.33%        1008               154    84.72%        1080               615    43.06%
TestUtils/MockReadLimiter.h                             2                 0   100.00%           2                 0   100.00%           5                 0   100.00%           0                 0         -
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                7655              1904    75.13%          96                 9    90.62%        2097               181    91.37%        2432              1237    49.14%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18088      10149            43.89%    200820  100961       49.73%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 04da47f into pingcap:master May 6, 2022
@jiaqizho jiaqizho deleted the rw-limiter branch May 6, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang left review comments

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jiaqizho @ti-chi-bot @sre-bot @flowbehappy @JaySon-Huang @CalvinNeo