Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chores(cmake): bump version to 3.21.0 #4162

Merged
merged 4 commits into from
Mar 25, 2022
Merged

chores(cmake): bump version to 3.21.0 #4162

merged 4 commits into from
Mar 25, 2022

Conversation

SchrodingerZhu
Copy link
Contributor

@SchrodingerZhu SchrodingerZhu commented Mar 1, 2022 •
edited
Loading

Signed-off-by: Schrodinger ZHU Yifan i@zhuyi.fan

What problem does this PR solve?

Issue Number: close #4138

  • Bump version to 3.21.0 because it is needed.
  • Some behaviors changed after changing.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@SchrodingerZhu SchrodingerZhu added the type/enhancement The issue or PR belongs to an enhancement. label Mar 1, 2022
@SchrodingerZhu SchrodingerZhu self-assigned this Mar 1, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • solotzg

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Mar 1, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 1, 2022
@SchrodingerZhu
Copy link
Contributor Author

/run-all-tests

@SchrodingerZhu
Copy link
Contributor Author

/run-unit-tests

1 similar comment
@solotzg
Copy link
Contributor

solotzg commented Mar 8, 2022

/run-unit-tests

solotzg
solotzg reviewed Mar 9, 2022
View reviewed changes
CMakeLists.txt Show resolved Hide resolved
@solotzg
Copy link
Contributor

solotzg commented Mar 9, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2022
@solotzg
Copy link
Contributor

solotzg commented Mar 9, 2022

/run-unit-tests

@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 16, 2022
@solotzg
Copy link
Contributor

solotzg commented Mar 21, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 21, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17020      9574             43.75%    191706  97063        49.37%

full coverage report (for internal network access only)

solotzg
solotzg approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@solotzg solotzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 21, 2022
@solotzg
Copy link
Contributor

solotzg commented Mar 21, 2022

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 22, 2022
@SchrodingerZhu
chores(cmake): bump version to 3.21.0
c45c164 
Signed-off-by: Schrodinger ZHU Yifan <i@zhuyi.fan>
Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 22, 2022
@SchrodingerZhu
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 25, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17046      9572             43.85%    191848  97041        49.42%

full coverage report (for internal network access only)

solotzg
solotzg reviewed Mar 25, 2022
View reviewed changes
dbms/CMakeLists.txt Show resolved Hide resolved
libs/libcommon/CMakeLists.txt Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2022
@solotzg
Copy link
Contributor

solotzg commented Mar 25, 2022

/merge

@ti-chi-bot
Copy link
Member

@solotzg: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 71fbc22

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Mar 25, 2022
@SchrodingerZhu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@SchrodingerZhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5e55b0a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 25, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17046      9572             43.85%    191848  97052        49.41%

full coverage report (for internal network access only)

@solotzg
Copy link
Contributor

solotzg commented Mar 25, 2022

/run-integration-test

@ti-chi-bot ti-chi-bot merged commit 0475ab9 into pingcap:master Mar 25, 2022
@JaySon-Huang JaySon-Huang deleted the cmake-version branch March 25, 2022 03:40
@SchrodingerZhu
address CR
71fbc22 
Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
@SchrodingerZhu
address CR
5e55b0a 
Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solotzg solotzg solotzg approved these changes

@zanmato1984 zanmato1984 zanmato1984 left review comments

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

@SchrodingerZhu SchrodingerZhu

Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake version constraint at main repo is not correct
6 participants
@SchrodingerZhu @ti-chi-bot @solotzg @sre-bot @zanmato1984 @JaySon-Huang