Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics of threads #4169

Merged
merged 10 commits into from
Mar 3, 2022
Merged

Metrics of threads #4169

merged 10 commits into from
Mar 3, 2022

Conversation

bestwoody
Copy link
Contributor

@bestwoody bestwoody commented Mar 2, 2022

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

new metrics:
    rpc: dispatch_mpp, establish_mpp
    threadpool: total, active
    threadfactory: total(active)

example: http://172.16.100.2:16205/d/SVbh2xUWk/woody-remote3-tiflash-summary?var-tidb_cluster=&var-instance=All. (Kongsoft Cloud)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: bestwoody <bestwoody@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 2, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker
  • yibin87

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 2, 2022
bestwoody and others added 2 commits March 2, 2022 13:39
Signed-off-by: bestwoody <bestwoody@163.com>
@bestwoody bestwoody requested a review from yibin87 March 2, 2022 06:23
@fuzhe1989 fuzhe1989 removed their request for review March 2, 2022 14:03
bestwoody and others added 3 commits March 3, 2022 12:05
Signed-off-by: bestwoody <bestwoody@163.com>
Signed-off-by: bestwoody <bestwoody@163.com>
@ti-chi-bot
Copy link
Member

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 3, 2022
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Mar 3, 2022
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 3, 2022
@bestwoody
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@bestwoody: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6449e14

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 3, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 3, 2022

Coverage for changed files

Filename                         Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/DynamicThreadPool.cpp          79                 1    98.73%          10                 0   100.00%          96                 1    98.96%          24                 1    95.83%
Common/Stopwatch.h                    32                11    65.62%          22                 7    68.18%          72                38    47.22%           6                 4    33.33%
Common/ThreadFactory.h                16                 0   100.00%           2                 0   100.00%          18                 0   100.00%           2                 1    50.00%
Common/TiFlashMetrics.h               18                 0   100.00%          11                 0   100.00%          47                 1    97.87%           8                 0   100.00%
Flash/Mpp/MPPTunnel.cpp              144               144     0.00%          14                14     0.00%         189               189     0.00%          64                64     0.00%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                289               156    46.02%          59                21    64.41%         422               229    45.73%         104                70    32.69%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16691      9456             43.35%    186850  95552        48.86%

full coverage report (for internal network access only)

@bestwoody bestwoody merged commit 05f5628 into pingcap:master Mar 3, 2022
@bestwoody bestwoody deleted the metrics_of_threads branch March 3, 2022 07:24
@fzhedu fzhedu mentioned this pull request Mar 11, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants