Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ddl job type of ActionRenameTables in TiFlash #4234

Merged
merged 10 commits into from
Mar 15, 2022
Merged

Support ddl job type of ActionRenameTables in TiFlash #4234

merged 10 commits into from
Mar 15, 2022

Conversation

CalvinNeo
Copy link
Member

Signed-off-by: CalvinNeo calvinneo1995@gmail.com

What problem does this PR solve?

Issue Number: close #4215

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Support ddl job type of `ActionRenameTables` in TiFlash

@CalvinNeo
add support for rename tables
3512ab5 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • jiaqizho

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2022
@CalvinNeo
Copy link
Member Author

/cc @JaySon-Huang @windtalker

@CalvinNeo
f
bf38ffa 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
fix
38893fb 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
add inte test
03bb1ab 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2022
@CalvinNeo
add test
8329d00 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2022
@CalvinNeo
Copy link
Member Author

/rebuild

@CalvinNeo
Copy link
Member Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 14, 2022

Coverage for changed files

Filename                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/DBGInvoker.cpp                             30                29     3.33%          10                 9    10.00%         139                75    46.04%          14                14     0.00%
Debug/MockTiDB.cpp                              144               140     2.78%          35                33     5.71%         453               435     3.97%          96                95     1.04%
Debug/MockTiDB.h                                  8                 6    25.00%           8                 6    25.00%          15                13    13.33%           0                 0         -
Debug/dbgFuncMockTiDBTable.cpp                  116               116     0.00%          15                15     0.00%         233               233     0.00%          76                76     0.00%
Storages/Transaction/SchemaBuilder.cpp          645               610     5.43%          46                42     8.70%        1024               952     7.03%         404               386     4.46%
Storages/Transaction/TiDBSchemaSyncer.h         109               101     7.34%          13                 9    30.77%         123                98    20.33%          38                37     2.63%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                          1052              1002     4.75%         127               114    10.24%        1987              1806     9.11%         628               608     3.18%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16777      9447             43.69%    188932  95743        49.32%

full coverage report (for internal network access only)

@CalvinNeo
Copy link
Member Author

/cc @jiaqizho

@CalvinNeo
r
175a23e 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

/run-all-tests

@CalvinNeo
f
9640f98 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

/run-all-tests

jiaqizho
jiaqizho reviewed Mar 15, 2022
View reviewed changes
dbms/src/Debug/dbgFuncMockTiDBTable.cpp Outdated Show resolved Hide resolved
dbms/src/Debug/MockTiDB.cpp Show resolved Hide resolved
@CalvinNeo
Copy link
Member Author

/run-unit-test

@CalvinNeo
f
ef9c024 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 15, 2022

Coverage for changed files

Filename                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/DBGInvoker.cpp                             30                29     3.33%          10                 9    10.00%         139                75    46.04%          14                14     0.00%
Debug/MockTiDB.cpp                              144               140     2.78%          35                33     5.71%         453               435     3.97%          96                95     1.04%
Debug/MockTiDB.h                                  8                 6    25.00%           8                 6    25.00%          15                13    13.33%           0                 0         -
Debug/dbgFuncMockTiDBTable.cpp                  116               116     0.00%          15                15     0.00%         233               233     0.00%          76                76     0.00%
Storages/Transaction/SchemaBuilder.cpp          649               614     5.39%          46                42     8.70%        1026               954     7.02%         406               388     4.43%
Storages/Transaction/TiDBSchemaSyncer.h         109               101     7.34%          13                 9    30.77%         123                98    20.33%          38                37     2.63%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                          1056              1006     4.73%         127               114    10.24%        1989              1808     9.10%         630               610     3.17%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16777      9447             43.69%    188934  95754        49.32%

full coverage report (for internal network access only)

@CalvinNeo
Copy link
Member Author

/run-all-tests

@CalvinNeo
Copy link
Member Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 15, 2022

Coverage for changed files

Filename                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/DBGInvoker.cpp                             30                29     3.33%          10                 9    10.00%         139                75    46.04%          14                14     0.00%
Debug/MockTiDB.cpp                              154               150     2.60%          35                33     5.71%         482               464     3.73%         102               101     0.98%
Debug/MockTiDB.h                                  8                 6    25.00%           8                 6    25.00%          15                13    13.33%           0                 0         -
Debug/dbgFuncMockTiDBTable.cpp                  116               116     0.00%          15                15     0.00%         233               233     0.00%          76                76     0.00%
Flash/Mpp/MPPTask.cpp                           395               395     0.00%          20                20     0.00%         328               328     0.00%         176               176     0.00%
Flash/Mpp/MPPTask.h                               3                 3     0.00%           3                 3     0.00%           3                 3     0.00%           0                 0         -
Flash/Mpp/MPPTaskManager.cpp                     97                96     1.03%          11                10     9.09%         173               172     0.58%          70                70     0.00%
Flash/Mpp/MPPTaskManager.h                        1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Flash/Mpp/MPPTunnel.cpp                         175               175     0.00%          16                16     0.00%         233               233     0.00%          90                90     0.00%
Flash/Mpp/MinTSOScheduler.cpp                   228               213     6.58%           7                 6    14.29%         145               135     6.90%         132               127     3.79%
Flash/Mpp/MinTSOScheduler.h                       4                 1    75.00%           2                 0   100.00%           4                 0   100.00%           4                 3    25.00%
Interpreters/Settings.h                           1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Storages/Transaction/SchemaBuilder.cpp          833               792     4.92%          46                42     8.70%        1036               964     6.95%         490               470     4.08%
Storages/Transaction/TMTContext.cpp              53                37    30.19%          34                19    44.12%         149               102    31.54%          12                11     8.33%
Storages/Transaction/TMTContext.h                 4                 3    25.00%           4                 3    25.00%           4                 3    25.00%           0                 0         -
Storages/Transaction/TiDBSchemaSyncer.h         109               101     7.34%          13                 9    30.77%         123                98    20.33%          38                37     2.63%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                          2211              2117     4.25%         226               191    15.49%        3069              2823     8.02%        1204              1175     2.41%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16922      9502             43.85%    190613  96469        49.39%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 15, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 15, 2022
@CalvinNeo
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@CalvinNeo: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: afd98b1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 15, 2022

Coverage for changed files

Filename                                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/DBGInvoker.cpp                                              30                29     3.33%          10                 9    10.00%         139                75    46.04%          14                14     0.00%
Debug/MockTiDB.cpp                                               154               150     2.60%          35                33     5.71%         482               464     3.73%         102               101     0.98%
Debug/MockTiDB.h                                                   8                 6    25.00%           8                 6    25.00%          15                13    13.33%           0                 0         -
Debug/dbgFuncMockTiDBTable.cpp                                   116               116     0.00%          15                15     0.00%         233               233     0.00%          76                76     0.00%
Flash/EstablishCall.h                                              2                 2     0.00%           2                 2     0.00%           2                 2     0.00%           0                 0         -
Flash/Mpp/MPPTask.cpp                                            395               395     0.00%          20                20     0.00%         328               328     0.00%         176               176     0.00%
Flash/Mpp/MPPTask.h                                                3                 3     0.00%           3                 3     0.00%           3                 3     0.00%           0                 0         -
Flash/Mpp/MPPTaskManager.cpp                                      97                96     1.03%          11                10     9.09%         173               172     0.58%          70                70     0.00%
Flash/Mpp/MPPTaskManager.h                                         1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Flash/Mpp/MPPTunnel.cpp                                          175               175     0.00%          16                16     0.00%         233               233     0.00%          90                90     0.00%
Flash/Mpp/MinTSOScheduler.cpp                                    228               213     6.58%           7                 6    14.29%         145               135     6.90%         132               127     3.79%
Flash/Mpp/MinTSOScheduler.h                                        4                 1    75.00%           2                 0   100.00%           4                 0   100.00%           4                 3    25.00%
Interpreters/Settings.h                                            1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Storages/DeltaMerge/Delta/ColumnFileFlushTask.cpp                 32                 2    93.75%           3                 0   100.00%          59                 5    91.53%          20                 2    90.00%
Storages/DeltaMerge/tests/gtest_dm_delta_merge_store.cpp        6008              1604    73.30%          37                 1    97.30%        2712                93    96.57%        2002               886    55.74%
Storages/StorageDeltaMerge.cpp                                   669               360    46.19%          56                29    48.21%        1292               762    41.02%         378               259    31.48%
Storages/Transaction/SchemaBuilder.cpp                           833               792     4.92%          46                42     8.70%        1036               964     6.95%         490               470     4.08%
Storages/Transaction/TMTContext.cpp                               53                37    30.19%          34                19    44.12%         149               102    31.54%          12                11     8.33%
Storages/Transaction/TMTContext.h                                  4                 3    25.00%           4                 3    25.00%           4                 3    25.00%           0                 0         -
Storages/Transaction/TiDBSchemaSyncer.h                          109               101     7.34%          13                 9    30.77%         123                98    20.33%          38                37     2.63%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                           8922              4085    54.21%         324               223    31.17%        7134              3685    48.35%        3604              2322    35.57%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16923      9504             43.84%    190677  96485        49.40%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 4c82be1 into pingcap:master Mar 15, 2022
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Mar 17, 2022
@CalvinNeo @JaySon-Huang
Support ddl job type of ActionRenameTables in TiFlash (pingcap#4234)
1d7010b 
close pingcap#4215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiaqizho jiaqizho jiaqizho approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@windtalker windtalker Awaiting requested review from windtalker

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support ddl job type of ActionRenameTables in TiFlash
5 participants
@CalvinNeo @ti-chi-bot @sre-bot @JaySon-Huang @jiaqizho