-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add HashJoinProbeBlockInputStream
#4246
Merged
Merged
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
46ed6ac
update
SeaRise 9c7860c
address comments
SeaRise 90b9a03
Merge branch 'master' into hash_probe_stream
SeaRise de076f4
Merge branch 'master' into hash_probe_stream
SeaRise c37fb89
add License
SeaRise c63bc0f
address comments
SeaRise 850874d
Update dbms/src/DataStreams/HashJoinProbeBlockInputStream.cpp
SeaRise 35bf4f7
Merge branch 'master' into hash_probe_stream
SeaRise 0272850
Merge branch 'master' into hash_probe_stream
ti-chi-bot 0ea1dcf
Merge branch 'master' into hash_probe_stream
ti-chi-bot a733242
Merge branch 'master' into hash_probe_stream
ti-chi-bot 3c026e8
Merge branch 'master' into hash_probe_stream
ti-chi-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
// Copyright 2022 PingCAP, Ltd. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
#include <DataStreams/HashJoinProbeBlockInputStream.h> | ||
#include <Flash/Mpp/getMPPTaskLog.h> | ||
#include <Interpreters/ExpressionActions.h> | ||
|
||
namespace DB | ||
{ | ||
HashJoinProbeBlockInputStream::HashJoinProbeBlockInputStream( | ||
const BlockInputStreamPtr & input, | ||
const ExpressionActionsPtr & expression_, | ||
const LogWithPrefixPtr & log_) | ||
: log(getMPPTaskLog(log_, name)) | ||
{ | ||
children.push_back(input); | ||
|
||
bool has_join_probe_action = false; | ||
if (expression_) | ||
{ | ||
for (const auto & action : expression_->getActions()) | ||
{ | ||
if (action.type == ExpressionAction::Type::JOIN) | ||
{ | ||
has_join_probe_action = true; | ||
break; | ||
} | ||
} | ||
} | ||
if (!has_join_probe_action) | ||
{ | ||
throw Exception("join probe expression should have join probe action", ErrorCodes::LOGICAL_ERROR); | ||
} | ||
expression = expression_; | ||
} | ||
|
||
Block HashJoinProbeBlockInputStream::getTotals() | ||
{ | ||
if (IProfilingBlockInputStream * child = dynamic_cast<IProfilingBlockInputStream *>(&*children.back())) | ||
{ | ||
totals = child->getTotals(); | ||
expression->executeOnTotals(totals); | ||
} | ||
|
||
return totals; | ||
} | ||
|
||
Block HashJoinProbeBlockInputStream::getHeader() const | ||
{ | ||
Block res = children.back()->getHeader(); | ||
expression->execute(res); | ||
return res; | ||
} | ||
|
||
Block HashJoinProbeBlockInputStream::readImpl() | ||
{ | ||
Block res = children.back()->read(); | ||
if (!res) | ||
return res; | ||
expression->execute(res); | ||
return res; | ||
} | ||
|
||
} // namespace DB |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
// Copyright 2022 PingCAP, Ltd. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
#pragma once | ||
|
||
#include <DataStreams/IProfilingBlockInputStream.h> | ||
|
||
namespace DB | ||
{ | ||
class ExpressionActions; | ||
|
||
/** Executes a certain expression over the block. | ||
* Basically the same as ExpressionBlockInputStream, | ||
* but requires that there must be a join probe action in the Expression. | ||
* | ||
* The join probe action is different from the general expression | ||
* and needs to be executed after join hash map building. | ||
* We should separate it from the ExpressionBlockInputStream. | ||
*/ | ||
class HashJoinProbeBlockInputStream : public IProfilingBlockInputStream | ||
{ | ||
private: | ||
using ExpressionActionsPtr = std::shared_ptr<ExpressionActions>; | ||
static constexpr auto name = "HashJoinProbe"; | ||
|
||
public: | ||
HashJoinProbeBlockInputStream( | ||
const BlockInputStreamPtr & input, | ||
const ExpressionActionsPtr & expression_, | ||
const LogWithPrefixPtr & log_); | ||
|
||
String getName() const override { return name; } | ||
Block getTotals() override; | ||
Block getHeader() const override; | ||
|
||
protected: | ||
Block readImpl() override; | ||
|
||
private: | ||
const LogWithPrefixPtr log; | ||
ExpressionActionsPtr expression; | ||
}; | ||
|
||
} // namespace DB |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since its name is
HashJoinProbeBlockInputStream
, how about just put a single join expressionAction here? I think this will be the first step for #3436There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard to use a single ExpressionAction...
But we can check that
actions.size() == 1 && actions.back().type == JOIN
...