Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine DAGStorageInterpreter #4312

Closed
wants to merge 5 commits into from
Closed

refine DAGStorageInterpreter #4312

wants to merge 5 commits into from

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Mar 16, 2022

What problem does this PR solve?

Issue Number: ref #4118

Problem Summary:

What is changed and how it works?

1、remove QueryBlock in DAGStorageInterpreter
2、replace String.operator+ by fmt::format

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 16, 2022
@SeaRise SeaRise requested a review from windtalker March 16, 2022 19:56
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 16, 2022
@SeaRise SeaRise requested a review from fuzhe1989 March 16, 2022 19:56
SeaRise
SeaRise commented Mar 17, 2022
View reviewed changes
dbms/src/Flash/Coprocessor/TiDBTableScan.h
@@ -48,10 +48,11 @@ class TiDBTableScan
}
String getTableScanExecutorID() const
{
return table_scan->executor_id();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

table_scan->executor_id() may be empty

@SeaRise SeaRise closed this Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker Awaiting requested review from windtalker

@fuzhe1989 fuzhe1989 Awaiting requested review from fuzhe1989

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SeaRise @ti-chi-bot