Add a pagestorage v3 controller. #4320

jiaqizho · 2022-03-17T03:22:15Z

Signed-off-by: jiaqizho zhoujiaqi@pingcap.com

What problem does this PR solve?

Issue Number: ref #3594

Problem Summary:

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

Signed-off-by: jiaqizho <zhoujiaqi@pingcap.com>

ti-chi-bot · 2022-03-17T03:22:16Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

CalvinNeo
JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

dbms/src/Storages/Page/V3/spacemap/SpaceMap.h

dbms/src/Storages/Page/V3/PageDirectory.h

dbms/src/Storages/Page/V3/tests/page_storage_ctl.cpp

dbms/src/Storages/Page/V3/spacemap/SpaceMap.cpp

dbms/src/Storages/Page/V3/tests/page_storage_ctl.cpp

jiaqizho · 2022-03-31T10:04:47Z

need some replacement with fmtbuffer.

CLAassistant · 2022-04-01T05:58:55Z

All committers have signed the CLA.

CLAassistant · 2022-04-01T05:59:40Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

jiaqizho · 2022-04-12T03:04:29Z

/hold

after all tests and fixed PR merged.
cc @JaySon-Huang

CalvinNeo

LGTM

jiaqizho · 2022-04-13T09:32:58Z

/unhold

jiaqizho · 2022-04-13T09:33:05Z

/merge

ti-chi-bot · 2022-04-13T09:33:06Z

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-04-13T09:33:07Z

This pull request has been accepted and is ready to merge.

Commit hash: a04249f

sre-bot · 2022-04-13T12:18:47Z

Coverage for changed files

Filename                        Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
BlobStore.cpp                       438               136    68.95%          49                 5    89.80%         952               241    74.68%         274               106    61.31%
BlobStore.h                           7                 1    85.71%           7                 1    85.71%          25                10    60.00%           0                 0         -
PageDirectory.h                      24                 4    83.33%          24                 4    83.33%         101                13    87.13%           0                 0         -
PageStorageImpl.h                     6                 2    66.67%           6                 2    66.67%           6                 2    66.67%           0                 0         -
spacemap/SpaceMap.cpp                33                 4    87.88%           7                 0   100.00%          54                15    72.22%          22                 7    68.18%
spacemap/SpaceMap.h                   7                 2    71.43%           4                 1    75.00%          18                 5    72.22%           6                 1    83.33%
spacemap/SpaceMapRBTree.cpp         320                78    75.62%          18                 1    94.44%         558               114    79.57%         190                58    69.47%
spacemap/SpaceMapRBTree.h             2                 0   100.00%           2                 0   100.00%           5                 0   100.00%           0                 0         -
spacemap/SpaceMapSTDMap.h           153                19    87.58%          11                 0   100.00%         247                20    91.90%          96                20    79.17%
tests/gtest_free_map.cpp           1848               309    83.28%          12                 0   100.00%         241                 0   100.00%         616               308    50.00%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                              2838               555    80.44%         140                14    90.00%        2207               420    80.97%        1204               500    58.47%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17023      9511             44.13%    191866  96450        49.73%

full coverage report (for internal network access only)

ti-chi-bot · 2022-04-14T05:10:45Z

@jiaqizho: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

sre-bot · 2022-04-14T05:46:16Z

Coverage for changed files

Filename                        Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
BlobStore.cpp                       438               136    68.95%          49                 5    89.80%         952               241    74.68%         274               106    61.31%
BlobStore.h                           7                 1    85.71%           7                 1    85.71%          25                10    60.00%           0                 0         -
PageDirectory.h                      24                 4    83.33%          24                 4    83.33%         101                13    87.13%           0                 0         -
PageStorageImpl.h                     6                 2    66.67%           6                 2    66.67%           6                 2    66.67%           0                 0         -
spacemap/SpaceMap.cpp                33                 4    87.88%           7                 0   100.00%          54                15    72.22%          22                 7    68.18%
spacemap/SpaceMap.h                   7                 2    71.43%           4                 1    75.00%          18                 5    72.22%           6                 1    83.33%
spacemap/SpaceMapRBTree.cpp         320                78    75.62%          18                 1    94.44%         558               114    79.57%         190                58    69.47%
spacemap/SpaceMapRBTree.h             2                 0   100.00%           2                 0   100.00%           5                 0   100.00%           0                 0         -
spacemap/SpaceMapSTDMap.h           153                19    87.58%          11                 0   100.00%         247                20    91.90%          96                20    79.17%
tests/gtest_free_map.cpp           1848               309    83.28%          12                 0   100.00%         241                 0   100.00%         616               308    50.00%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                              2838               555    80.44%         140                14    90.00%        2207               420    80.97%        1204               500    58.47%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17025      9512             44.13%    191972  96455        49.76%

full coverage report (for internal network access only)

Add a pagestorage v3 control.

1981465

Signed-off-by: jiaqizho <zhoujiaqi@pingcap.com>

ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 17, 2022

jiaqizho changed the title ~~Add a pagestorage v3 control.~~ Add a pagestorage v3 controller. Mar 17, 2022

update

0307372

jiaqizho requested a review from JaySon-Huang March 17, 2022 03:53

JaySon-Huang reviewed Mar 17, 2022

View reviewed changes

dbms/src/Storages/Page/V3/spacemap/SpaceMap.h Outdated Show resolved Hide resolved

dbms/src/Storages/Page/V3/spacemap/SpaceMap.h Outdated Show resolved Hide resolved

dbms/src/Storages/Page/V3/PageDirectory.h Outdated Show resolved Hide resolved

jiaqizho added 3 commits March 17, 2022 20:33

update

be09ba8

fix build

ff75f7b

merge to master

cba4fc3

JaySon-Huang reviewed Mar 18, 2022

View reviewed changes

dbms/src/Storages/Page/V3/tests/page_storage_ctl.cpp Outdated Show resolved Hide resolved

JaySon-Huang reviewed Mar 18, 2022

View reviewed changes

dbms/src/Storages/Page/V3/tests/page_storage_ctl.cpp Outdated Show resolved Hide resolved

jiaqizho added 2 commits March 18, 2022 13:59

rm test_utils

7254e88

update

d09e53c

JaySon-Huang reviewed Mar 18, 2022

View reviewed changes

dbms/src/Storages/Page/V3/spacemap/SpaceMap.cpp Show resolved Hide resolved

JaySon-Huang reviewed Mar 18, 2022

View reviewed changes

dbms/src/Storages/Page/V3/tests/page_storage_ctl.cpp Outdated Show resolved Hide resolved

temp commit

f5a469d

jiaqizho requested a review from CalvinNeo March 21, 2022 05:57

jiaqizho added 2 commits March 21, 2022 15:24

update

664df34

update

4ddb6d2

ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 21, 2022

JaySon-Huang reviewed Mar 22, 2022

View reviewed changes

dbms/src/Storages/Page/V3/tests/page_storage_ctl.cpp Outdated Show resolved Hide resolved

update

17b2e9d

jiaqizho requested a review from JaySon-Huang March 24, 2022 01:52

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2022

merge to master

7bb6a1f

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2022

jiaqizho added 2 commits April 1, 2022 15:32

update

c1644ee

add license

fcaa8bc

JaySon-Huang approved these changes Apr 12, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 12, 2022

ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2022

Merge branch 'master' into add-ps-v3-ctl

a04249f

CalvinNeo approved these changes Apr 13, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 13, 2022

ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2022

ti-chi-bot removed the do-not-merge/needs-linked-issue label Apr 14, 2022

jiaqizho and others added 3 commits April 14, 2022 10:13

Merge branch 'master' into add-ps-v3-ctl

bff5d62

Merge branch 'master' into add-ps-v3-ctl

07a9e4e

Merge branch 'master' into add-ps-v3-ctl

d73dc20

ti-chi-bot merged commit 402e477 into pingcap:master Apr 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a pagestorage v3 controller. #4320

Add a pagestorage v3 controller. #4320

jiaqizho commented Mar 17, 2022 •

edited

Loading

ti-chi-bot commented Mar 17, 2022 •

edited

Loading

jiaqizho commented Mar 31, 2022

CLAassistant commented Apr 1, 2022 •

edited

Loading

CLAassistant commented Apr 1, 2022

jiaqizho commented Apr 12, 2022

CalvinNeo left a comment

jiaqizho commented Apr 13, 2022

jiaqizho commented Apr 13, 2022

ti-chi-bot commented Apr 13, 2022

ti-chi-bot commented Apr 13, 2022

sre-bot commented Apr 13, 2022

ti-chi-bot commented Apr 14, 2022

sre-bot commented Apr 14, 2022

Add a pagestorage v3 controller. #4320

Add a pagestorage v3 controller. #4320

Conversation

jiaqizho commented Mar 17, 2022 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Mar 17, 2022 • edited Loading

jiaqizho commented Mar 31, 2022

CLAassistant commented Apr 1, 2022 • edited Loading

CLAassistant commented Apr 1, 2022

jiaqizho commented Apr 12, 2022

CalvinNeo left a comment

Choose a reason for hiding this comment

jiaqizho commented Apr 13, 2022

jiaqizho commented Apr 13, 2022

ti-chi-bot commented Apr 13, 2022

ti-chi-bot commented Apr 13, 2022

sre-bot commented Apr 13, 2022

Coverage for changed files

Coverage summary

ti-chi-bot commented Apr 14, 2022

sre-bot commented Apr 14, 2022

Coverage for changed files

Coverage summary

jiaqizho commented Mar 17, 2022 •

edited

Loading

ti-chi-bot commented Mar 17, 2022 •

edited

Loading

CLAassistant commented Apr 1, 2022 •

edited

Loading