Fix ThreadSanitizer: std::localtime() is not thread-safe.

[Lloyd-Pottiger]

Replace thread-unsafe std::localtime() in DB::UnifiedLogPatternFormatter::getTimestamp() with localtime_r()

What problem does this PR solve?

Issue Number: close #4303

Problem Summary:

What is changed and how it works?

Replace thread-unsafe std::localtime() in DB::UnifiedLogPatternFormatter::getTimestamp() with localtime_r(). Because std::localtime() is not thread-safe, localtime_r() is thread-safe.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• JaySon-Huang
• JinheLin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[JaySon-Huang]

LGTM

[SchrodingerZhu]

null pointer on error (which may be a runtime constraint violation or a failure to convert the specified time to local calendar time)

LGTM, but shall we check null pointers (i.e. throw exceptions instead)? cc @JaySon-Huang

[JaySon-Huang]

null pointer on error (which may be a runtime constraint violation or a failure to convert the specified time to local calendar time)

LGTM, but shall we check null pointers (i.e. throw exceptions instead)? cc @JaySon-Huang

Good catch. However, throwing exceptions maybe not a good idea, cause the exception usually is thrown to BaseDaemon, and leads to more logs while printing those exceptions. It will make things out of control.

I think if localtime_r() return nullptr, just return "0000/00/00 00:00:00.000 00000"?
/cc @SchrodingerZhu @Lloyd-Pottiger

---

Finally we decide to use "1970/01/01 00:00:00.000 +00:00" for invalid result

[SchrodingerZhu]

I think if localtime_r() return nullptr, just return "0000/00/00 00:00:00.000 00000"?

LGTM.

[JaySon-Huang]

LGTM with minor comment

[Lloyd-Pottiger]

/merge

[ti-chi-bot]

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

@Lloyd-Pottiger: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[JaySon-Huang]

@SchrodingerZhu @JinheLin PTAL again

[Lloyd-Pottiger]

/run-unit-test

[sre-bot]

Coverage for changed files

Filename                                                                                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Common/UnifiedLogPatternFormatter.cpp          78                25    67.95%           6                 0   100.00%         166                44    73.49%          78                26    66.67%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                              78                25    67.95%           6                 0   100.00%         166                44    73.49%          78                26    66.67%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17016      9573             43.74%    191597  97039        49.35%

full coverage report (for internal network access only)

[JaySon-Huang]

/merge

[ti-chi-bot]

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 93498da

[sre-bot]

Coverage for changed files

Filename                                                                                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Common/UnifiedLogPatternFormatter.cpp          78                25    67.95%           6                 0   100.00%         166                44    73.49%          78                27    65.38%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                              78                25    67.95%           6                 0   100.00%         166                44    73.49%          78                27    65.38%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17016      9573             43.74%    191597  97044        49.35%

full coverage report (for internal network access only)

[sre-bot]

Coverage for changed files

Filename                                                                                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Common/UnifiedLogPatternFormatter.cpp          78                25    67.95%           6                 0   100.00%         166                44    73.49%          78                28    64.10%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                              78                25    67.95%           6                 0   100.00%         166                44    73.49%          78                28    64.10%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17031      9576             43.77%    191844  97041        49.42%

full coverage report (for internal network access only)