Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace LOG_XXX with LOG_FMT_XXX in dbms/src/Dictionaries, dbms/src/Flash and dbms/src/Interpreters #4410

Merged
merged 9 commits into from
Mar 25, 2022
Merged

replace LOG_XXX with LOG_FMT_XXX in dbms/src/Dictionaries, dbms/src/Flash and dbms/src/Interpreters #4410

merged 9 commits into from
Mar 25, 2022

Conversation

Lloyd-Pottiger
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #4346

Problem Summary:

What is changed and how it works?

replace LOG_XXX with LOG_FMT_XXX in dbms/src/Dictionaries, dbms/src/Flash and dbms/src/Interpreters and skip LOG_TRACE which have been changed by @ywqzzy in #4375

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@Lloyd-Pottiger
improve interpreters log
24cbdbd 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger
improve flash log
75f0cac 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger
improve dictionaries log
04ea6a1 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 24, 2022
@Lloyd-Pottiger
format
b096071 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 24, 2022
@Lloyd-Pottiger Lloyd-Pottiger self-assigned this Mar 24, 2022
@Lloyd-Pottiger
clear clang-tidy error
2dd8d90 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
JaySon-Huang
JaySon-Huang reviewed Mar 24, 2022
View reviewed changes
dbms/src/Flash/Mpp/ExchangeReceiver.cpp Outdated Show resolved Hide resolved
dbms/src/Flash/Mpp/MPPTunnel.cpp Outdated Show resolved Hide resolved
@Lloyd-Pottiger
recover some unnecessary opperation
b5578b6 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger
make up for some missing revise
cccfb60
@Lloyd-Pottiger
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 24, 2022

Coverage for changed files

Filename                                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Dictionaries/Embedded/RegionsHierarchy.cpp          59                59     0.00%           2                 2     0.00%         104               104     0.00%          42                42     0.00%
Dictionaries/Embedded/RegionsNames.cpp              48                48     0.00%           3                 3     0.00%          61                61     0.00%          28                28     0.00%
Flash/LogSearch.cpp                                221                45    79.64%          14                 0   100.00%         357                61    82.91%         158                54    65.82%
Flash/Mpp/ExchangeReceiver.cpp                     302               302     0.00%          31                31     0.00%         450               450     0.00%         188               188     0.00%
Interpreters/Aggregator.cpp                       2621              2621     0.00%          74                74     0.00%        1602              1602     0.00%        1202              1202     0.00%
Interpreters/ExternalLoader.cpp                    173               173     0.00%          14                14     0.00%         266               266     0.00%         116               116     0.00%
Interpreters/ExternalLoader.h                        3                 3     0.00%           3                 3     0.00%           3                 3     0.00%           0                 0         -
Interpreters/InterpreterSelectQuery.cpp            526               526     0.00%          52                52     0.00%         919               919     0.00%         438               438     0.00%
Interpreters/SharedQueries.h                        22                22     0.00%           8                 8     0.00%         110               110     0.00%          12                12     0.00%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                             3975              3799     4.43%         201               187     6.97%        3872              3576     7.64%        2184              2080     4.76%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17033      9568             43.83%    191929  97046        49.44%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2022
JaySon-Huang
JaySon-Huang approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 24, 2022
@JaySon-Huang
Copy link
Contributor

/merge

1 similar comment
@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cccfb60

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2022
@ti-chi-bot
Copy link
Member

@Lloyd-Pottiger: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 25, 2022

Coverage for changed files

Filename                                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Dictionaries/Embedded/RegionsHierarchy.cpp          59                59     0.00%           2                 2     0.00%         104               104     0.00%          42                42     0.00%
Dictionaries/Embedded/RegionsNames.cpp              48                48     0.00%           3                 3     0.00%          61                61     0.00%          28                28     0.00%
Flash/LogSearch.cpp                                221                45    79.64%          14                 0   100.00%         357                61    82.91%         158                54    65.82%
Flash/Mpp/ExchangeReceiver.cpp                     302               302     0.00%          31                31     0.00%         450               450     0.00%         188               188     0.00%
Interpreters/Aggregator.cpp                       2621              2621     0.00%          74                74     0.00%        1602              1602     0.00%        1202              1202     0.00%
Interpreters/ExternalLoader.cpp                    173               173     0.00%          14                14     0.00%         266               266     0.00%         116               116     0.00%
Interpreters/ExternalLoader.h                        3                 3     0.00%           3                 3     0.00%           3                 3     0.00%           0                 0         -
Interpreters/InterpreterSelectQuery.cpp            526               526     0.00%          52                52     0.00%         919               919     0.00%         438               438     0.00%
Interpreters/SharedQueries.h                        22                22     0.00%           8                 8     0.00%         110               110     0.00%          12                12     0.00%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                             3975              3799     4.43%         201               187     6.97%        3872              3576     7.64%        2184              2080     4.76%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17046      9572             43.85%    191755  96972        49.43%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit ac37930 into pingcap:master Mar 25, 2022
@JaySon-Huang JaySon-Huang deleted the improve-dict-flash-interp-log branch March 25, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywqzzy ywqzzy ywqzzy approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

@Lloyd-Pottiger Lloyd-Pottiger

Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Lloyd-Pottiger @ti-chi-bot @sre-bot @JaySon-Huang @ywqzzy