-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add more checks for background segment split (#4406) #4417
add more checks for background segment split (#4406) #4417
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
@VelocityLight: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: f8662ab
|
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
This is an automated cherry-pick of #4406
What problem does this PR solve?
Issue Number: close #4408
Problem Summary: After syncing data from tikv using snapshot, there are some too large segments.
What is changed and how it works?
Add more check for background split.
Check List
Tests
Load tpch100 into tiflash(set tiflash replica after data loaded into tikv), and check the segments stat using query:
select
rows
from information_schema.tiflash_segments wheretable
="t_144" order byrows
;Before fix:
After fix:
Side effects
Documentation
Release note